[FEATURE] Extensible version support#256
Merged
sdatkinson merged 3 commits intomainfrom Apr 26, 2026
Merged
Conversation
Introduce a pluggable version-support checker registry and route config version validation through it, so downstream projects can register scoped version policies without editing get_dsp directly. Made-with: Cursor
Simplify the version support checker contract to a single support(version) call, with checker-specific pattern filtering handled internally by returning NO for non-applicable formats. Made-with: Cursor
Add tests for core version support classification and custom checker registration so the extensible version support path is validated end-to-end in the test runner. Made-with: Cursor
synchu
pushed a commit
to synchu/NeuralAmpModelerCore
that referenced
this pull request
Apr 29, 2026
* [FEATURE] Add extensible model version support registry Introduce a pluggable version-support checker registry and route config version validation through it, so downstream projects can register scoped version policies without editing get_dsp directly. Made-with: Cursor * [REFACTOR] Remove version checker matches() API Simplify the version support checker contract to a single support(version) call, with checker-specific pattern filtering handled internally by returning NO for non-applicable formats. Made-with: Cursor * [TEST] Add version support coverage for get_dsp Add tests for core version support classification and custom checker registration so the extensible version support path is validated end-to-end in the test runner. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending projects can define extensions to supported
"version"s in .nam files. As demonstrated int eh test, one could for example develop an extension to this repo, develop .nam files with a version"DEMO::1.0.0"(and also register their respective DSP subclasses), and still useget_dsp()from this repo without worrying that it'll think that it doesn't know how to use the model you point it at. Also allows for different extensions to Core to be developed with independent versioning.AI PR Description:
Summary
get_dspto use a pluggable checker interface (IVersionSupportChecker) and a support-level enum (Supported: NO/PARTIAL/YES).register_version_support_checker(...), and routes version decisions throughis_version_supported(...)so core and custom checkers can coexist.run_tests.Why
Changes
NAM/get_dsp.hSupportedenum.IVersionSupportCheckerinterface.register_version_support_checker(...)andis_version_supported(...)APIs.NAM/get_dsp.cppCoreVersionSupportChecker.verify_config_version(...)to useis_version_supported(...).tools/test/test_get_dsp.cpptest_is_version_supported_core_behavior.test_register_custom_version_support_checker.tools/run_tests.cppTest Plan
cmake --build build --target run_tests./build/tools/run_testsSuccess!)test_get_dspcases execute inrun_tests