Merged
Conversation
(おそらく kohya-ss@be14c06 の修正漏れ )
…or consistent validation
Fix validation epoch divergence
Fix sizes for validation split
…-recorder Fix validation epoch loss to check epoch average
Fix validation split and add test
The postions_ids cause errors for the newer version of transformer. This has already been fixed in convert_ldm_clip_checkpoint_v1() but not in v2. The new code applies the same fix to convert_ldm_clip_checkpoint_v2().
Remove position_ids for V2
Remove v-pred warning.
Move progress bar to account for sampling image first
Update IPEX libs
Val loss improvement
Author
|
This was working fine but when it swaps to validation it is having device mismatches. Working through the code to try and figure that out. Might be because it's a sequential module which would need to be fixed to work. The goal with this is to make block swapping work so running and training Gemma 2 LoRA would be more available. Also might be possible to engage with block swapping for Gemma 2 to make it a little more compatible. |
Author
|
Needed |
Author
|
Sample images had similar issues and now is working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #16
Enables block swap for Lumina