Skip to content

fix don's skip parent#354

Merged
steiler merged 5 commits intosdcio:FixSdcpbPathMultikeyfrom
swisscom:FixSdcpbPathMultikey
Oct 23, 2025
Merged

fix don's skip parent#354
steiler merged 5 commits intosdcio:FixSdcpbPathMultikeyfrom
swisscom:FixSdcpbPathMultikey

Conversation

@faebr
Copy link
Contributor

@faebr faebr commented Oct 21, 2025

The Bug
In checkAndCreateKeysAsLeafs, when a key already exists with the correct owner, the code does continue to skip to the next iteration. However, it was skipping the crucial statement that moves up the tree to get the next key value.

@faebr
Copy link
Contributor Author

faebr commented Oct 22, 2025

Added fix for ParseDecimal64 to parse after yang defined Decimal64: https://www.rfc-editor.org/rfc/rfc6020.html#section-9.3

@steiler steiler merged commit 633d641 into sdcio:FixSdcpbPathMultikey Oct 23, 2025
8 of 10 checks passed
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 65.78947% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/utils/value.go 70.96% 7 Missing and 2 partials ⚠️
pkg/utils/converter.go 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henderiw henderiw moved this to Backlog in SDC project Jan 19, 2026
@github-project-automation github-project-automation bot moved this from Backlog to Done in SDC project Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants