Remove alabaster-shellgenius and tighten key.env parsing#7
Conversation
* drop the unsupported `alabaster-shellgenius` preset and legacy fallback * remove hidden `--plain`, `-p`, and `--command-only` aliases in favor of `--raw` and `--cmd` * keep shared `~/.config/lmt/...` behavior and default prompt routing intact * update tests and the changelog note for the retrocompat cleanup Co-authored-by: AI <ai@sderev.com>
* Parse `~/.config/lmt/key.env` as a dedicated ShellGenius key file * Keep `OPENAI_API_KEY=...`, quoted values, and `export OPENAI_API_KEY=...` * Reject bare key lines and unrelated assignments, with tests and a changelog fragment Co-authored-by: AI <ai@sderev.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6135b698e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if line.startswith("export OPENAI_API_KEY="): | ||
| value = line[len("export OPENAI_API_KEY=") :] | ||
| elif line.startswith("OPENAI_API_KEY="): | ||
| value = line[len("OPENAI_API_KEY=") :] | ||
| # Strip optional surrounding quotes. | ||
| if len(value) >= 2 and value[0] == value[-1] and value[0] in ("'", '"'): | ||
| value = value[1:-1] | ||
| return value.strip() | ||
|
|
||
| if line == "OPENAI_API_KEY": | ||
| saw_other_content = True | ||
| continue | ||
|
|
||
| if "=" in line: | ||
| saw_other_content = True | ||
| continue | ||
|
|
||
| if bare_key or saw_other_content: | ||
| saw_other_content = True | ||
| continue | ||
| else: |
There was a problem hiding this comment.
export in key.env
The new parser only accepts lines starting with the exact prefix export OPENAI_API_KEY=, so valid shell-style exports like export OPENAI_API_KEY=... or export\tOPENAI_API_KEY=... are now rejected and the key resolves to empty. This is a regression from the previous behavior and can silently break existing ~/.config/lmt/key.env files that include extra spacing while still being semantically the same assignment.
Useful? React with 👍 / 👎.
|
@codex review |
sderev
force-pushed
the
remove-alabaster-shellgenius
branch
from
6135b69 to
f52e7d1
Compare
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
What changed
alabaster-shellgeniuspreset, its legacy fallback, and the hidden CLI aliases--plain,-p, and--command-only.~/.config/lmt/key.envparsing so ShellGenius acceptsOPENAI_API_KEY=..., quoted values, andexport OPENAI_API_KEY=..., while rejecting bare key lines and unrelated assignments.README.md, regression tests, and changelog fragments for both user-facing changes.Why
key.envas a valid API key source.How to test
gate.shellgenius --raw "show the current git branch",shellgenius --rich "show the current git branch", andshellgenius --cmd "show the current git branch"to confirm the supported output options still work and the removed hidden aliases are gone.~/.config/lmt/key.envto verify acceptedOPENAI_API_KEYforms still load and malformed content is rejected.Risk/comp notes
alabaster-shellgeniuspreset.key.envmust switch to explicitOPENAI_API_KEY=...syntax.Changelog fragment: yes (and why)