Launch script#114
Conversation
CI MessageYour results will arrive shortly |
onvm
left a comment
onvm
left a comment
There was a problem hiding this comment.
In response to PR creation
CI Message
Run successful see results:
✔️ PR submitted to develop branch
✔️ Speed tester performance check passed
[Results from nimbnode30]
- Median TX pps for Speed Tester: 35192022
- Performance rating - 100.55% (compred to 35000000 average)
Linter Failed
examples/arp_response/arp_response.c:284: Lines should be <= 120 characters long [whitespace/line_length] [5]
Total errors found: 1
examples/flow_table/openflow.h:50: Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
examples/flow_table/openflow.h:569: Extra space before ( in function call [whitespace/parens] [4]
examples/flow_table/openflow.h:634: Extra space before ( in function call [whitespace/parens] [4]
examples/flow_table/openflow.h:771: Extra space before ( in function call [whitespace/parens] [4]
examples/flow_table/openflow.h:804: Extra space before ( in function call [whitespace/parens] [4]
examples/flow_table/openflow.h:865: Extra space before ( in function call [whitespace/parens] [4]
examples/flow_table/openflow.h:926: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 7
examples/nf_router/nf_router.c:173: Lines should be <= 120 characters long [whitespace/line_length] [5]
Total errors found: 1
examples/payload_scan/payload_scan.c:95: Lines should be <= 120 characters long [whitespace/line_length] [5]
examples/payload_scan/payload_scan.c:114: Almost always, snprintf is better than strcpy [runtime/printf] [4]
examples/payload_scan/payload_scan.c:126: Lines should be <= 120 characters long [whitespace/line_length] [5]
Total errors found: 3
onvm/onvm_mgr/onvm_pkt.c:68: Are you taking an address of a cast? This is dangerous: could be a temp var. Take the address before doing the cast, rather than after [runtime/casting] [4]
Total errors found: 1
onvm/onvm_mgr/onvm_stats.c:306: If an else has a brace on one side, it should have it on both [readability/braces] [5]
Total errors found: 1
onvm/onvm_nflib/onvm_pkt_common.c:98: Are you taking an address of a cast? This is dangerous: could be a temp var. Take the address before doing the cast, rather than after [runtime/casting] [4]
Total errors found: 1
|
@onvm do your thing 😉 |
CI MessageYour results will arrive shortly |
onvm
left a comment
onvm
left a comment
There was a problem hiding this comment.
@onvm do your thing 😉
CI Message
Run successful see results:
✔️ PR submitted to develop branch
✔️ Speed tester performance check passed
✔️ Linter passed
[Results from nimbnode30]
- Median TX pps for Speed Tester: 35209607
- Performance rating - 100.60% (compred to 35000000 average)
koolzz
left a comment
koolzz
left a comment
There was a problem hiding this comment.
Above there is a exec sudo $BINARY -F $config $CONFIG_ARGS for config file launch, lets also fix that. Otherwise looks good, tested with a few speed_tester & paylaod_scan cmds.
| dash_dash_cnt=0 | ||
| arg_cnt=0 | ||
| for i in "$@" ; do | ||
| if [[ dash_dash_cnt -le 1 ]] ; then |
There was a problem hiding this comment.
Could we make it -lt 2 (seems to me a bit more intuitive)
|
|
||
| # Check if -- is present, if so parse dpdk/onvm specific args | ||
| dash_dash_cnt=0 | ||
| arg_cnt=0 |
There was a problem hiding this comment.
Maybe something like non_nf_arg_cnt to be more specific?
| DPDK_ARGS="$DPDK_BASE_ARGS $(echo " ""$@" | awk -F "--" '{print $1;}')" | ||
| ONVM_ARGS="$(echo " ""$@" | awk -F "--" '{print $2;}')" | ||
| NF_ARGS="$(echo " ""$@" | awk -F "--" '{print $3;}')" | ||
|
|
|
This one is next @onvm |
CI MessageYour results will arrive shortly |
onvm
left a comment
onvm
left a comment
There was a problem hiding this comment.
This one is next @onvm
CI Message
Run successful see results:
✔️ PR submitted to develop branch
✔️ Speed tester performance check passed
✔️ Linter passed
[Results from nimbnode30]
- Median TX pps for Speed Tester: 35205648
- Performance rating - 100.59% (compared to 35000000 average)
3 participants
From Issue 107, go script couldn't handle multi-word string arguments
Summary:
Specifically in the
payload_scanNF, running with the required./go.sh 1 -d 1 -s "My String Here"would not work with multiple words. While./go.sh 1 -d 1 -s computeror "computer" works well, bash strips the quotes with variable assignment, so "computer here" would become computer here. Thus the cgetoptwould not recognize the wordhere.Usage:
Merging notes:
TODO before merging :
Test Plan:
Run multiple NFs with tons of arguments to ensure the go script doesn't fail. Make sure to run with DPDK arguments as well, to check that errors are handled correctly still. Only adding DPDK without ONVM args should fail, from previous edits to go scripts.
Sanity checks, assigned to @koolzz @dennisafa
Run linter
Check for scripting errors
Performance, assigned to @koolzz @dennisafa