Skip to content

[Bug Fix] Resolve Stats Print Order#132

Merged
koolzz merged 1 commit intosdnfv:developfrom
koolzz:stats_ordering_fix
Jun 3, 2019
Merged

[Bug Fix] Resolve Stats Print Order#132
koolzz merged 1 commit intosdnfv:developfrom
koolzz:stats_ordering_fix

Conversation

@koolzz
Copy link
Copy Markdown
Member

@koolzz koolzz commented Jun 3, 2019

We were swapping the printing of children count and parent id

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

  • Dependencies: None

TODO before merging :

  • PR is ready for review

Test Plan:

Review:

(optional) << @-mention people who should review these changes >>

(optional) Subscribers: << @-mention people who probably care about these changes >>

@onvm
Copy link
Copy Markdown

onvm commented Jun 3, 2019

In response to PR creation

CI Message

Your results will arrive shortly

@koolzz koolzz added this to the ONVM 19.05 Release milestone Jun 3, 2019
@koolzz
Copy link
Copy Markdown
Member Author

koolzz commented Jun 3, 2019

@kevindweb CI died, I reset it. @onvm do the thing

@onvm
Copy link
Copy Markdown

onvm commented Jun 3, 2019

@kevindweb CI died, I reset it. @onvm do the thing

CI Message

Your results will arrive shortly

Copy link
Copy Markdown

@onvm onvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevindweb CI died, I reset it. @onvm do the thing

CI Message

Run successful see results:
✔️ PR submitted to develop branch
✔️ Speed tester performance check passed
✔️ Linter passed

[Results from nimbnode30]

  • Median TX pps for Speed Tester: 39248996
  • Performance rating - 112.14% (compared to 35000000 average)

@koolzz koolzz merged commit 3355c6d into sdnfv:develop Jun 3, 2019
@koolzz koolzz deleted the stats_ordering_fix branch June 7, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants