Update Extra Verbose Stats Display#136
Conversation
CI MessageYour results will arrive shortly |
onvm
left a comment
onvm
left a comment
There was a problem hiding this comment.
In response to PR creation
CI Message
Run successful see results:
✔️ PR submitted to develop branch
✔️ Speed tester performance check passed
❌ Linter Failed (please fix style errors)
[Results from nimbnode30]
- Median TX pps for Speed Tester: 38062395
- Performance rating - 108.75% (compared to 35000000 average)
Linter Output
onvm/onvm_mgr/onvm_stats.c:133: Potential format string bug. Do printf("%s", ONVM_STATS_RAW_DUMP_PORT_MSG) instead. [runtime/printf] [4]
onvm/onvm_mgr/onvm_stats.c:134: Potential format string bug. Do printf("%s", ONVM_STATS_RAW_DUMP_NF_MSG) instead. [runtime/printf] [4]
Total errors found: 2
onvm/onvm_mgr/onvm_stats.h:76: Lines should very rarely be longer than 150 characters [whitespace/line_length] [4]
Total errors found: 1
|
@onvm again |
CI MessageYour results will arrive shortly |
onvm
left a comment
onvm
left a comment
There was a problem hiding this comment.
@onvm again
CI Message
Run successful see results:
✔️ PR submitted to develop branch
✔️ Speed tester performance check passed
✔️ Linter passed
[Results from nimbnode30]
- Median TX pps for Speed Tester: 38140617
- Performance rating - 108.97% (compared to 35000000 average)
|
Also added the descriptions of stats output in the README.md for onvm/ |
2 participants
The Extra Verbose stats display was missing a few of the new stats (parent_id, children_cnt, state was printed as int not a char). This pr fixes both the verbose stats header and the verbose stats output.
@kevindweb does this look good?