[Bug Fix] Return Proper Error Codes for NF Init Failure#137
Merged
koolzz merged 2 commits intosdnfv:developfrom Jun 4, 2019
Merged
[Bug Fix] Return Proper Error Codes for NF Init Failure#137koolzz merged 2 commits intosdnfv:developfrom
koolzz merged 2 commits intosdnfv:developfrom
Conversation
CI MessageYour results will arrive shortly |
onvm
approved these changes
Jun 4, 2019
onvm
left a comment
onvm
left a comment
There was a problem hiding this comment.
In response to PR creation
CI Message
Run successful see results:
✔️ PR submitted to develop branch
✔️ Speed tester performance check passed
✔️ Linter passed
[Results from nimbnode30]
- Median TX pps for Speed Tester: 38465710
- Performance rating - 109.90% (compared to 35000000 average)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly return error codes on NF init failure
Summary:
Usage:
Check error codes
Merging notes:
TODO before merging :
Test Plan:
Review:
@dennisafa @kevindweb would appreciate if you tested/reviewed this.