Style guide link#152
Merged
koolzz merged 2 commits intosdnfv:developfrom Jul 31, 2019
Merged
Conversation
Member
|
@onvm CI check links |
CI MessageYour results will arrive shortly |
onvm
approved these changes
Jul 28, 2019
onvm
left a comment
onvm
left a comment
There was a problem hiding this comment.
@onvm CI check links
CI Message
Run successful see results:
✔️ PR submitted to develop branch
✔️ Pktgen performance check passed
✔️ Speed Test performance check passed
✔️ mTCP performance check passed
✔️ Linter passed
[Results from nimbnode17]
-
Median TX pps for Speed Tester: 40189595
Performance rating - 100.47% (compared to 40000000 average) -
Median TX pps for Pktgen: 9896088
Performance rating - 98.96% (compared to 10000000 average) -
Time (ms) per request for mTCP and Apache Benchmark: 0.236000
Performance rating - 102.61% (compared to 0.230000 average)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 Links were never fixed from #113 referencing issue #67
Summary:
Made 2 changes to links, and a one ` character change for Markdown formatting. Go here to make sure the links look good.
Merging notes:
TODO before merging :
Review:
@dennisafa