Upgrading from Ubuntu 14.04.1 to 18.04.1 by dennisafa · Pull Request #72 · sdnfv/openNetVM

dennisafa · 2019-03-04T19:48:00Z

Modifies necessary files to make ONVM compatible with Ubuntu 18.04.1 LTS

Summary:

With the new Ubuntu version comes an upgraded version of gcc, which has stricter checks in place with regards to strict aliasing, formatting, etc. This pull request modifies code where these errors occured.

Usage:

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes	👍
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

Dependencies: None

TODO before merging :

PR is ready for review
Test pktgen
Test mTCP

Test Plan:

Testing was done on a bare-metal cloudlab node running 18.04.1. Speed tester was run with the following results:

Speed tester
1 NF	52 million pkt/s
2 NF	18 million pkt/s

Update: testing with pktgen resulted in a peak of 7 million pps.

Review:

Sanity checks, assigned to @koolzz
- Run make in /onvm and /examples directories
- Test new functionality or bug fix from the pr (if needed)
Code style, assigned to @koolzz
- Run linter
- Check everything style related
Code design, assigned to @koolzz
- Check for memory leaks
- Check that code is reusable
- Code is clean, functions are concise
- Verify that edge cases properly handled
Performance, assigned to @koolzz
- Run Speed Tester NF, report performance.
- Run pktgen, report performance (if needed)
- Run mTCP epserver, verify wget works, report performance for epwget/ab (if needed)
Documentation, assigned to @koolzz
- Check if the new changes are well documented, in both code and READMEs

… ubuntu18

koolzz · 2019-03-06T18:27:10Z

                            /* 10xxxxxx */
                            *--ptr2 = ((uc | 0x80) & 0xBF);
                            uc >>= 6;
+                            break;


This technically changes the behavior, instead of falling through all the cases it only does the one.

Although I'm not sure what the expected behavior is anyway. Should we just get a new cJSON version?

edit: added comments to let the statement fallthrough without triggering the compiler warning. i will look into new cJSON versions.

koolzz · 2019-03-09T19:17:07Z

@onvm whats so different about the public repo

onvm · 2019-03-09T19:17:14Z

openNetVM

CI Message

Your results will arrive shortly

onvm · 2019-03-09T19:17:28Z

openNetVM

CI Message

Error: ERROR: Failed to fetch and checkout pull request

Linter Passed

koolzz · 2019-03-09T19:28:53Z

@onvm public repo = no pexpect pwd. @AaronCoplan 👍

koolzz · 2019-03-09T19:37:44Z

@onvm one more time with the right response message?

onvm · 2019-03-09T19:37:51Z

@onvm one more time with the right response message?

CI Message

Your results will arrive shortly

koolzz · 2019-03-09T19:38:05Z

@onvm show people what happens when you're busy working

onvm · 2019-03-09T19:38:09Z

@onvm show people what happens when you're busy working

CI Message

Another CI run in progress, please try again in 15 minutes

onvm · 2019-03-09T19:44:26Z

@onvm one more time with the right response message?

CI Message

Run successful see results:
[Results from nimbnode30]
Median TX pps for Speed Tester: 35156774

Linter Failed

examples/aes_decrypt/aes.c:523: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/aes_decrypt/aes.c:1024: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/aes_decrypt/aes.c:1028: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/aes_decrypt/aes.c:1081: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/aes_decrypt/aes.c:1087: If an else has a brace on one side, it should have it on both [readability/braces] [5]
Total errors found: 5
examples/aes_encrypt/aes.c:523: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/aes_encrypt/aes.c:1024: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/aes_encrypt/aes.c:1028: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/aes_encrypt/aes.c:1081: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/aes_encrypt/aes.c:1087: If an else has a brace on one side, it should have it on both [readability/braces] [5]
Total errors found: 5
examples/arp_response/arp_response.c:144: Missing space before ( in switch( [whitespace/parens] [5]
Total errors found: 1
examples/bridge/bridge.c:135: Missing space before ( in if( [whitespace/parens] [5]
examples/bridge/bridge.c:138: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/bridge/bridge.c:156: If an else has a brace on one side, it should have it on both [readability/braces] [5]
Total errors found: 3
examples/flow_table/flow_table.c:103: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/flow_table.c:198: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/flow_table.c:216: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/flow_table.c:224: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/flow_table.c:231: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/flow_table/flow_table.c:238: If an else has a brace on one side, it should have it on both [readability/braces] [5]
Total errors found: 6
examples/flow_table/msgbuf.c:71: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:73: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:83: Missing space before ( in while( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:86: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:89: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:106: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:108: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:116: Missing space before ( in while( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:119: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:125: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:138: Extra space before last semicolon. If this should be an empty statement, use {} instead. [whitespace/semicolon] [5]
examples/flow_table/msgbuf.c:140: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:149: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:157: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:159: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:162: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/msgbuf.c:169: Missing space before ( in while( [whitespace/parens] [5]
Total errors found: 17
examples/flow_table/sdn.c:99: Extra space before last semicolon. If this should be an empty statement, use {} instead. [whitespace/semicolon] [5]
examples/flow_table/sdn.c:125: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/sdn.c:127: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/sdn.c:147: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/flow_table/sdn.c:147: Missing space before { [whitespace/braces] [5]
examples/flow_table/sdn.c:153: Missing space before ( in while( [whitespace/parens] [5]
examples/flow_table/sdn.c:160: Missing space before { [whitespace/braces] [5]
examples/flow_table/sdn.c:235: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/flow_table/sdn.c:239: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/flow_table/sdn.c:279: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/sdn.c:418: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/sdn.c:423: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/sdn.c:493: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/flow_table/sdn.c:501: If an else has a brace on one side, it should have it on both [readability/braces] [5]
examples/flow_table/sdn.c:538: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/sdn.c:542: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/sdn.c:545: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/sdn.c:547: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/sdn.c:555: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/sdn.c:569: Missing space before ( in while( [whitespace/parens] [5]
Total errors found: 20
examples/flow_table/setupconn.c:82: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/setupconn.c:89: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/setupconn.c:94: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/setupconn.c:102: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/setupconn.c:110: Missing space before { [whitespace/braces] [5]
examples/flow_table/setupconn.c:112: Missing space before { [whitespace/braces] [5]
examples/flow_table/setupconn.c:122: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/setupconn.c:140: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/setupconn.c:149: Missing space before ( in if( [whitespace/parens] [5]
examples/flow_table/setupconn.c:156: Missing space before ( in if( [whitespace/parens] [5]
Total errors found: 10
examples/flow_tracker/flow_tracker.c:108: Missing space before ( in switch( [whitespace/parens] [5]
examples/flow_tracker/flow_tracker.c:210: If an else has a brace on one side, it should have it on both [readability/braces] [5]
Total errors found: 2
examples/scaling_example/scaling.c:312: Missing space before ( in while( [whitespace/parens] [5]
Total errors found: 1
onvm/onvm_mgr/main.c:98: Mismatching spaces inside () in while [whitespace/parens] [5]
Total errors found: 1
onvm/onvm_mgr/onvm_args.c:166: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_mgr/onvm_args.c:166: Missing space before { [whitespace/braces] [5]
onvm/onvm_mgr/onvm_args.c:172: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_mgr/onvm_args.c:172: Missing space before { [whitespace/braces] [5]
onvm/onvm_mgr/onvm_args.c:328: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_mgr/onvm_args.c:352: Missing space before { [whitespace/braces] [5]
onvm/onvm_mgr/onvm_args.c:357: Missing space before ( in if( [whitespace/parens] [5]
Total errors found: 7
onvm/onvm_mgr/onvm_init.c:222: Never use sprintf. Use snprintf instead. [runtime/printf] [5]
Total errors found: 1
onvm/onvm_mgr/onvm_nf.c:182: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_mgr/onvm_nf.c:255: Missing space before ( in if( [whitespace/parens] [5]
Total errors found: 2
onvm/onvm_mgr/onvm_stats.c:183: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_mgr/onvm_stats.c:183: Missing space before { [whitespace/braces] [5]
Total errors found: 2
onvm/onvm_nflib/onvm_config_common.c:52: Missing space before { [whitespace/braces] [5]
onvm/onvm_nflib/onvm_config_common.c:112: Missing space before ( in for( [whitespace/parens] [5]
onvm/onvm_nflib/onvm_config_common.c:112: Missing space before { [whitespace/braces] [5]
onvm/onvm_nflib/onvm_config_common.c:417: Never use sprintf. Use snprintf instead. [runtime/printf] [5]
onvm/onvm_nflib/onvm_config_common.c:433: Never use sprintf. Use snprintf instead. [runtime/printf] [5]
onvm/onvm_nflib/onvm_config_common.c:487: Never use sprintf. Use snprintf instead. [runtime/printf] [5]
Total errors found: 6
onvm/onvm_nflib/onvm_flow_dir.c:64: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_nflib/onvm_flow_dir.c:95: Missing space before { [whitespace/braces] [5]
onvm/onvm_nflib/onvm_flow_dir.c:103: Missing space before { [whitespace/braces] [5]
onvm/onvm_nflib/onvm_flow_dir.c:111: Missing space before { [whitespace/braces] [5]
onvm/onvm_nflib/onvm_flow_dir.c:128: Missing space before { [whitespace/braces] [5]
onvm/onvm_nflib/onvm_flow_dir.c:143: Missing space before { [whitespace/braces] [5]
onvm/onvm_nflib/onvm_flow_dir.c:151: Missing space before { [whitespace/braces] [5]
onvm/onvm_nflib/onvm_flow_dir.c:159: Missing space before { [whitespace/braces] [5]
onvm/onvm_nflib/onvm_flow_dir.c:176: Missing space before { [whitespace/braces] [5]
Total errors found: 9
onvm/onvm_nflib/onvm_nflib.c:341: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_nflib/onvm_nflib.c:344: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_nflib/onvm_nflib.c:347: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_nflib/onvm_nflib.c:351: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_nflib/onvm_nflib.c:354: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_nflib/onvm_nflib.c:357: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_nflib/onvm_nflib.c:584: Missing space before ( in switch( [whitespace/parens] [5]
onvm/onvm_nflib/onvm_nflib.c:743: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_nflib/onvm_nflib.c:754: Missing space before ( in if( [whitespace/parens] [5]
onvm/onvm_nflib/onvm_nflib.c:821: Missing space before { [whitespace/braces] [5]
Total errors found: 10
onvm/onvm_nflib/onvm_pkt_helper.c:313: Missing space before ( in switch( [whitespace/parens] [5]
onvm/onvm_nflib/onvm_pkt_helper.c:376: Missing space before { [whitespace/braces] [5]
Total errors found: 2

koolzz

Tested on cloudlab, builds fine with these changes

koolzz · 2019-03-13T21:47:41Z

@dennisafa were you able to get mTCP running with this?

dennisafa · 2019-03-14T05:00:10Z

@dennisafa were you able to get mTCP running with this?

i haven't had a chance to try out mTCP quite yet. i'll get that done by the end of the day.

koolzz · 2019-03-21T15:17:23Z

As discussed in the meeting, mTCP might have some code not compatible with ubuntu 18.04.1. This pr should still be good to merge as long as Pktgen & onvm works. Will setup the ubuntu 18.04.1 cloudlab experiment and merge if everything functions as expected.

dennisafa · 2019-03-21T16:52:42Z

As discussed in the meeting, mTCP might have some code not compatible with ubuntu 18.04.1. This pr should still be good to merge as long as Pktgen & onvm works. Will setup the ubuntu 18.04.1 cloudlab experiment and merge if everything functions as expected.

mTCP compatibility could be made into a separate PR.

koolzz · 2019-03-21T17:30:48Z

Yeah, and it would be in the mtcp repo anyway.

dennisafa and others added 30 commits February 26, 2019 12:33

Updating makefiles

b389069

Updating makefiles for gcc 7.3.0

5150db8

Update Makefile

35b7f72

Updating Makefiles for Ubuntu 18.04.1 LTS compatibility

65dfcb3

Updating Makefiles

0c49ce4

Update Makefile

e2e4a97

Update onvm_common.h

8efae82

Update onvm_common.h

198c026

Update onvm_common.h

672284b

Update onvm_common.h

1c6233e

Update cJSON.c

363868c

Update onvm_nflib.c

8e41fea

Update onvm_nflib.c

af2ef8d

testing

62225a4

Update cJSON.c

ae69259

tests

914709d

testing

da21e23

Update Makefile

fe1417c

Update onvm_init.c

1cb89c4

Update onvm_init.c

17d680b

Update onvm_init.c

6221713

Update onvm_init.c

207f0ea

Update onvm_init.c

63c6e9b

Update onvm_init.c

54e98a4

Remove no changes

125db1b

Merge branch 'develop' of https://github.com/sdnfv/openNetVM-dev into…

08c00a4

… ubuntu18

Removing modified pr file

734e5cd

Removing modified pr file

32fd8c6

Removing modified pr file

4381fd6

Removing modified pr file

1002a00

koolzz self-requested a review March 4, 2019 19:49

koolzz reviewed Mar 6, 2019

View reviewed changes

dennisa added 2 commits March 6, 2019 14:06

Fallthrough comments

72dd933

Update fallthrough comments

6505739

sdnfv deleted a comment from onvm Mar 9, 2019

This comment has been minimized.

Sign in to view

koolzz approved these changes Mar 12, 2019

View reviewed changes

koolzz added the enhancement 🚀 label Mar 14, 2019

dennisafa mentioned this pull request Mar 18, 2019

Adding a Firewall NF #80

Merged

4 tasks

koolzz merged commit f8488cc into sdnfv:develop Mar 21, 2019

dennisafa deleted the ubuntu18 branch April 27, 2019 02:53

koolzz added this to the ONVM 19.05 Release milestone May 26, 2019

Conversation

dennisafa commented Mar 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Merging notes:

Test Plan:

Review:

Uh oh!

koolzz Mar 6, 2019

Choose a reason for hiding this comment

Uh oh!

dennisafa Mar 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koolzz commented Mar 9, 2019

Uh oh!

onvm commented Mar 9, 2019

CI Message

Uh oh!

onvm commented Mar 9, 2019

CI Message

Linter Passed

Uh oh!

koolzz commented Mar 9, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

koolzz commented Mar 9, 2019

Uh oh!

onvm commented Mar 9, 2019

CI Message

Uh oh!

koolzz commented Mar 9, 2019

Uh oh!

onvm commented Mar 9, 2019

CI Message

Uh oh!

onvm commented Mar 9, 2019

CI Message

Linter Failed

Uh oh!

koolzz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koolzz commented Mar 13, 2019

Uh oh!

dennisafa commented Mar 14, 2019

Uh oh!

koolzz commented Mar 21, 2019

Uh oh!

dennisafa commented Mar 21, 2019

Uh oh!

koolzz commented Mar 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dennisafa commented Mar 4, 2019 •

edited

Loading

dennisafa Mar 6, 2019 •

edited

Loading

koolzz left a comment •

edited

Loading

koolzz commented Mar 21, 2019 •

edited

Loading