Replace old FlowTracker NF go.sh script with symlink #74
Merged
koolzz merged 1 commit intosdnfv:developfrom Mar 7, 2019
Merged
Replace old FlowTracker NF go.sh script with symlink #74koolzz merged 1 commit intosdnfv:developfrom
koolzz merged 1 commit intosdnfv:developfrom
Conversation
Member
Author
|
@dennisafa from what I recall it might need ip headers. Can you try replaying the pcap file with speed tester |
dennisafa
reviewed
Mar 6, 2019
Member
dennisafa
left a comment
dennisafa
left a comment
There was a problem hiding this comment.
NF runs using newly configured go script. Looped packets from speed_tester to flow_tracker. Is current capacity supposed to fill up? It displays 0/100 consistently, even with rx_pps/tx_pps showing up. Reached speed of 17 million pps.
dennisafa
approved these changes
Mar 6, 2019
Member
dennisafa
left a comment
dennisafa
left a comment
There was a problem hiding this comment.
NF runs using newly configured go script. Looped packets from speed_tester to flow_tracker using pktgen_big.pcap file. 9.1 million pps result. Flow_tracker printed messages properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the old go.sh script with a new go.sh symlink.
Summary:
Missed this one on the go.sh revolution PR.
Merging notes:
TODO before merging :
Test Plan:
Run the NF.
Review:
Whoever runs the NF and reports the result. 1 Approval is enough.
@dennisafa @kevindweb