Add core number to web stats by kevindweb · Pull Request #89 · sdnfv/openNetVM

kevindweb · 2019-03-24T21:23:10Z

Adds a core number label in the web stats view for each running network function.

Summary:

Since getting access to the nf_info->core, we wanted to add this information to our web statistics. In the future the core mapping page will be updated, showing all NFs and manager on their specific cores. Building the web app has to delete and recreate many files, which is why there are so many "changes". There are only 2 line changes from /onvm/onvm_mgr/onvm_stats.c

Usage:
See the web stats documentation for information about running the React website.

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates	👍

Merging notes:

Dependencies: None

TODO before merging :

PR is ready for review

Test Plan:

Run the web stats with ./go.sh 0,1,2 1 0xF8 -s web and run speed tester nfs to see if the core number affects the website.

Review:

Sanity checks, assigned to @koolzz @Arjun-Vijay
- Run make in /onvm and /examples directories
- Code style, assigned to @koolzz @Arjun-Vijay
Run linter
- Check everything style related
- Code design, assigned to @koolzz @Arjun-Vijay
Check for memory leaks
- Check that code is reusable
- Code is clean, functions are concise
- Verify that edge cases properly handled
Performance, assigned to @koolzz @Arjun-Vijay
- Run Speed Tester NF, report performance.
Documentation, assigned to @koolzz @Arjun-Vijay
- Check if the new changes are well documented, in both code and READMEs

onvm · 2019-03-24T21:23:17Z

In response to PR creation

CI Message

Your results will arrive shortly

koolzz · 2019-03-24T21:52:48Z

Pull the latest Dev branch commits, there shouldn't be any linter issues

koolzz · 2019-03-24T21:55:52Z

I see this rebuild the web stuff so all good

AaronCoplan · 2019-03-24T21:55:59Z

Based on the fact this PR has updates to files within the onvm_web/web-build/ path, it's an indicator that @kevindweb has already run the build. But yes we will want to run it one more time before merging to ensure that the files are up to date.

kevindweb · 2019-03-25T03:17:55Z

@onvm let's try again

onvm · 2019-03-25T03:18:02Z

@onvm let's try again

CI Message

Your results will arrive shortly

onvm · 2019-03-25T03:25:09Z

@onvm let's try again

CI Message

Run successful see results:
[Results from nimbnode30]
Median TX pps for Speed Tester: 35161576

Linter Passed

koolzz · 2019-03-28T04:06:02Z

I clicked on this first, brace yourselves for some CI emails

@onvm gooo

koolzz · 2019-03-28T04:31:05Z

@onvm hello

koolzz · 2019-03-28T04:36:52Z

@onvm bump

koolzz · 2019-03-28T04:37:18Z

@onvm bump

koolzz · 2019-03-28T04:38:57Z

@onvm boomp

koolzz · 2019-03-28T04:39:25Z

@onvm bip bop

koolzz · 2019-03-28T04:41:35Z

@onvm pls

koolzz · 2019-03-28T04:42:38Z

@onvm go

koolzz · 2019-03-28T04:51:08Z

@onvm gogogo

koolzz · 2019-03-28T04:51:44Z

@onvm тык

onvm · 2019-03-28T04:51:51Z

@onvm тык

CI Message

Your results will arrive shortly

onvm · 2019-03-28T04:57:52Z

@onvm тык

CI Message

Error: ERROR: Script failed on nimbnode30

Linter Passed

koolzz · 2019-03-28T04:58:09Z

@onvm good good again

onvm · 2019-03-28T04:58:16Z

@onvm good good again

CI Message

Your results will arrive shortly

koolzz · 2019-03-28T05:00:22Z

@onvm тык

onvm · 2019-03-28T05:00:26Z

@onvm тык

CI Message

Another CI run in progress, please try again in 15 minutes

onvm · 2019-03-28T05:05:02Z

@onvm good good again

CI Message

Run successful see results:
[Results from nimbnode30]
Median TX pps for Speed Tester: 35158836

Linter Passed

koolzz · 2019-03-28T05:07:10Z

@onvm pls work I wanna sleep

onvm · 2019-03-28T05:07:18Z

@onvm pls work I wanna sleep

CI Message

Your results will arrive shortly

koolzz · 2019-03-28T05:12:27Z

@onvm last time

onvm · 2019-03-28T05:12:34Z

@onvm last time

CI Message

Your results will arrive shortly

koolzz · 2019-03-28T05:13:13Z

@onvm well now last time for sure

onvm · 2019-03-28T05:13:20Z

@onvm well now last time for sure

CI Message

Your results will arrive shortly

onvm · 2019-03-28T05:16:31Z

@onvm well now last time for sure

CI Message

Error: ERROR: Script failed on nimbnode30

Linter Passed

koolzz

Move the doc changes to a separate PR. Otherwise I tested it and it works.

koolzz · 2019-03-28T21:39:26Z

@@ -1,57 +1,59 @@
-Debugging OpenNetVM
-==
+# Debugging OpenNetVM


A few doc changes are fine to mix in with other PRs, but you have this + install doc which is about 400 line changes. Can you move it to another PR?

Sorry I didn't see this, I'll fix it

koolzz · 2019-03-29T15:47:14Z

@kevindweb Could you look into adding a minify step to the CSS and JS files to the build? This would fix our problem with the build being too inflated (this pr alone is 55k line changes right now)

…_core

kevindweb · 2019-04-02T04:43:47Z

Finally got minified files to work! @onvm check it out one last time

onvm · 2019-04-02T04:43:54Z

Finally got minified files to work! @onvm check it out one last time

CI Message

Your results will arrive shortly

onvm · 2019-04-02T04:51:17Z

Finally got minified files to work! @onvm check it out one last time

CI Message

Run successful see results:
[Results from nimbnode30]
Median TX pps for Speed Tester: 35211377

Linter Passed

koolzz

Tested everything works as expected, great work on minifying everything. One tweak to this, can we automatically install uglifycss and uglify-js? Or even just creating a build README with all the dependencies would be useful, or do we have that somewhere?

Add core number to web stats

eb93e71

This comment has been minimized.

Sign in to view

Merging with develop changes

dea9890

koolzz self-requested a review March 26, 2019 05:08

koolzz added the enhancement 🚀 label Mar 28, 2019

koolzz requested changes Mar 28, 2019

View reviewed changes

kevindweb added 6 commits April 1, 2019 20:28

Merge branch 'develop' of https://github.com/sdnfv/openNetVM into web…

e7bd2b1

…_core

Reverted back markdown files

fe72527

Rebuilt and minified content

8b9254c

Updated minification process

5d66523

Testing minify

cdf85f6

Removed husky

4a961d3

koolzz approved these changes Apr 2, 2019

View reviewed changes

Updated README with build information

0a33044

koolzz merged commit b8d7deb into sdnfv:develop Apr 3, 2019

koolzz added this to the ONVM 19.05 Release milestone May 26, 2019

kevindweb deleted the web_core branch June 1, 2019 22:16

Conversation

kevindweb commented Mar 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Merging notes:

Test Plan:

Review:

Uh oh!

onvm commented Mar 24, 2019

CI Message

Uh oh!

This comment has been minimized.

koolzz commented Mar 24, 2019

Uh oh!

koolzz commented Mar 24, 2019

Uh oh!

AaronCoplan commented Mar 24, 2019

Uh oh!

kevindweb commented Mar 25, 2019

Uh oh!

onvm commented Mar 25, 2019

CI Message

Uh oh!

onvm commented Mar 25, 2019

CI Message

Linter Passed

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

onvm commented Mar 28, 2019

CI Message

Uh oh!

onvm commented Mar 28, 2019

CI Message

Linter Passed

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

onvm commented Mar 28, 2019

CI Message

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

onvm commented Mar 28, 2019

CI Message

Uh oh!

onvm commented Mar 28, 2019

CI Message

Linter Passed

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

onvm commented Mar 28, 2019

CI Message

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

onvm commented Mar 28, 2019

CI Message

Uh oh!

koolzz commented Mar 28, 2019

Uh oh!

kevindweb commented Mar 24, 2019 •

edited

Loading