Conversation
There was a problem hiding this comment.
Pull request overview
Updates the CLI to align with a newer Go/tooling baseline and the latest sdotee/sdk.go, adding new subcommands for domain discovery and private file download URLs.
Changes:
- Bump
github.com/sdotee/sdk.gofromv1.1.1tov1.2.0and update module/tooling Go version to1.26. - Add
see text domainsandsee file download-url <file-id>commands (plus tests for the file command structure/args). - Update README with usage for the new file download URL command and bump Makefile VERSION.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
go.mod |
Updates Go version and bumps sdotee/sdk.go dependency. |
go.sum |
Updates checksums for the new sdotee/sdk.go version. |
cmd/text.go |
Adds text domains subcommand that calls apiClient.GetTextDomains(). |
cmd/file.go |
Adds file download-url subcommand calling apiClient.GetPrivateFileDownloadURL(...). |
cmd/file_test.go |
Extends command structure tests and adds args validation tests for download-url. |
README.md |
Documents see file download-url <file-id>. |
Makefile |
Bumps CLI build VERSION to 1.1.0. |
.mise.toml |
Pins local Go toolchain version for developers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
56
to
60
| textCmd.AddCommand(textCreateCmd) | ||
| textCmd.AddCommand(textUpdateCmd) | ||
| textCmd.AddCommand(textDeleteCmd) | ||
| textCmd.AddCommand(textDomainsCmd) | ||
|
|
There was a problem hiding this comment.
New see text domains subcommand is added here, but the README’s “Text” section doesn’t document it. Please update README.md to include this command so user-facing docs stay in sync with the CLI surface area.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.