Add unit tests for remove_inputs in InputObserver#423
Merged
Conversation
Co-authored-by: xadupre <22452781+xadupre@users.noreply.github.com>
xadupre
approved these changes
Feb 23, 2026
Copilot
AI
changed the title
[WIP] Add remove_inputs to InputObserver
Add unit tests for Feb 23, 2026
remove_inputs in InputObserver
sdpython
pushed a commit
that referenced
this pull request
Feb 24, 2026
* add remove_inputs to InputObserver * changes * mypy * Add unit tests for `remove_inputs` in `InputObserver` (#423) * Initial plan * Add unit tests for remove_inputs in InputObserver Co-authored-by: xadupre <22452781+xadupre@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: xadupre <22452781+xadupre@users.noreply.github.com> * a few fixes * Update onnx_diagnostic/investigate/input_observer.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix * style * update doc * fix documentation --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: xadupre <22452781+xadupre@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove_inputswas added toInputObserver,InputObserverInfo, andInputCandidatebut had no test coverage.Changes
test_remove_inputs_kwargs: Verifies removing a single kwarg ("z") propagates correctly throughinfer_dynamic_shapes()andinfer_arguments().test_remove_inputs_multiple_kwargs: Verifies removing multiple kwargs ("z","w") at once leaves remaining inputs ("x","y") intact and correctly shaped.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.