Traceback when setting parallelize to false

[steinybot]

In the absence of #143 I am trying to disable parallization however if I try and do so then I get a Traceback.

To reproduce use the following .overcommit.yml file:

CommitMsg:
  MessageFormat:
    enabled: true
    parallelize: false
    pattern: '^(GEN|AUX|BX)-\d+'

Then try and commit.

Traceback:

Running pre-commit hooks

✓ All pre-commit hooks passed

Running commit-msg hooks
Run JiraIssueKey.......................................[JiraIssueKey] OK
Traceback (most recent call last):
	8: from .git/hooks/commit-msg:80:in `<main>'
	7: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:30:in `run'
	6: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/interrupt_handler.rb:86:in `isolate_from_interrupts'
	5: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:45:in `block in run'
	4: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:66:in `run_hooks'
	3: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/interrupt_handler.rb:65:in `disable_until_finished_or_interrupted'
	2: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:67:in `block in run_hooks'
	1: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:67:in `each'
/Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:67:in `join': No live threads left. Deadlock? (fatal)
7 threads, 7 sleeps current:0x00007f927627c6e0 main thread:0x00007f9273c0b8d0
* #<Thread:0x00007f9274064088 sleep_forever>
   rb_thread_t:0x00007f9273c0b8d0 native:0x000000010b6015c0 int:0
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:67:in `join'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:67:in `each'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:67:in `block in run_hooks'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/interrupt_handler.rb:65:in `disable_until_finished_or_interrupted'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:66:in `run_hooks'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:45:in `block in run'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/interrupt_handler.rb:86:in `isolate_from_interrupts'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:30:in `run'
   .git/hooks/commit-msg:80:in `<main>'
* #<Thread:0x00007f92741f3700@/Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:93 sleep_forever>
   rb_thread_t:0x00007f927627a600 native:0x00007000024c6000 int:0
    depended by: tb_thread_id:0x00007f9273c0b8d0
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `sleep'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `wait'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `block (2 levels) in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `block in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `synchronize'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:161:in `run_hook'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:97:in `block in consume'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `consume'
* #<Thread:0x00007f92741f3598@/Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:93 sleep_forever>
   rb_thread_t:0x00007f927627aa90 native:0x00007000025c9000 int:0
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `sleep'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `wait'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `block (2 levels) in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `block in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `synchronize'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:161:in `run_hook'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:97:in `block in consume'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `consume'
* #<Thread:0x00007f92741f3430@/Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:93 sleep_forever>
   rb_thread_t:0x00007f927627af20 native:0x00007000026cc000 int:0
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `sleep'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `wait'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `block (2 levels) in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `block in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `synchronize'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:161:in `run_hook'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:97:in `block in consume'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `consume'
* #<Thread:0x00007f92741f32c8@/Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:93 sleep_forever>
   rb_thread_t:0x00007f927627b3e0 native:0x00007000027cf000 int:0
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `sleep'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `wait'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `block (2 levels) in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `block in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `synchronize'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:161:in `run_hook'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:97:in `block in consume'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `consume'
* #<Thread:0x00007f92741f3160@/Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:93 sleep_forever>
   rb_thread_t:0x00007f927627b8a0 native:0x00007000028d2000 int:0
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `sleep'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `wait'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `block (2 levels) in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `block in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `synchronize'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:161:in `run_hook'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:97:in `block in consume'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `consume'
* #<Thread:0x00007f92741f2ff8@/Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:93 sleep_forever>
   rb_thread_t:0x00007f927627bd60 native:0x00007000029d5000 int:0
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `sleep'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `wait'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `block (2 levels) in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `block in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `synchronize'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:161:in `run_hook'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:97:in `block in consume'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `consume'

[sds]

Thanks for the report. I'm unfortunately unable to reproduce this behavior using Ruby 2.6.3 on macOS.

With that said, I see there is a JiraIssueKey hook in your output. This looks like a custom hook. Are you able to reproduce this using only built-in hooks?

[steinybot]

Sorry that was an error that I copied from a different configuration. I can reproduce it in a brand new git repo with just the MessageFormat hook:

➜  overcommit-bug git:(master) ✗ cat .overcommit.yml
# Use this file to configure the Overcommit hooks you wish to use. This will
# extend the default configuration defined in:
# https://github.com/sds/overcommit/blob/master/config/default.yml
#
# At the topmost level of this YAML file is a key representing type of hook
# being run (e.g. pre-commit, commit-msg, etc.). Within each type you can
# customize each hook, such as whether to only run it on certain files (via
# `include`), whether to only display output if it fails (via `quiet`), etc.
#
# For a complete list of hooks, see:
# https://github.com/sds/overcommit/tree/master/lib/overcommit/hook
#
# For a complete list of options that you can use to customize hooks, see:
# https://github.com/sds/overcommit#configuration

CommitMsg:
  MessageFormat:
    enabled: true
    parallelize: false
    pattern: '^(GEN|AUX|BX)-\d+'
➜  overcommit-bug git:(master) ✗ git status
On branch master

No commits yet

Changes to be committed:
  (use "git rm --cached <file>..." to unstage)

	new file:   .overcommit.yml

➜  overcommit-bug git:(master) ✗ git commit -m "Initial commit"
Running pre-commit hooks

✓ All pre-commit hooks passed

Running commit-msg hooks
Check commit message matches expected pattern.........[MessageFormat] FAILED
Commit message pattern mismatch.
Expected : <Issue Id> | <Commit Message Description> | <Developer(s)>
Sample : DEFECT-1234 | Refactored Onboarding flow | John Doe
Traceback (most recent call last):
	8: from .git/hooks/commit-msg:80:in `<main>'
	7: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:30:in `run'
	6: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/interrupt_handler.rb:86:in `isolate_from_interrupts'
	5: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:45:in `block in run'
	4: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:66:in `run_hooks'
	3: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/interrupt_handler.rb:65:in `disable_until_finished_or_interrupted'
	2: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:67:in `block in run_hooks'
	1: from /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:67:in `each'
/Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:67:in `join': No live threads left. Deadlock? (fatal)
6 threads, 6 sleeps current:0x00007fdd6b40b750 main thread:0x00007fdd6b40b750
* #<Thread:0x00007fdd6b864098 sleep_forever>
   rb_thread_t:0x00007fdd6b40b750 native:0x000000010d8a45c0 int:0
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:67:in `join'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:67:in `each'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:67:in `block in run_hooks'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/interrupt_handler.rb:65:in `disable_until_finished_or_interrupted'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:66:in `run_hooks'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:45:in `block in run'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/interrupt_handler.rb:86:in `isolate_from_interrupts'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:30:in `run'
   .git/hooks/commit-msg:80:in `<main>'
* #<Thread:0x00007fdd6d881308@/Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:93 sleep_forever>
   rb_thread_t:0x00007fdd6d084680 native:0x0000700002051000 int:0
    depended by: tb_thread_id:0x00007fdd6b40b750
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `sleep'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `wait'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `block (2 levels) in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `block in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `synchronize'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:161:in `run_hook'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:97:in `block in consume'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `consume'
* #<Thread:0x00007fdd6d8811a0@/Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:93 sleep_forever>
   rb_thread_t:0x00007fdd6d084b10 native:0x0000700002154000 int:0
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `sleep'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `wait'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `block (2 levels) in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `loop'
# Use this file to configure the Overcommit hooks you wish to use. This will
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `block in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `synchronize'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:161:in `run_hook'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:97:in `block in consume'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `consume'
* #<Thread:0x00007fdd6d881038@/Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:93 sleep_forever>
   rb_thread_t:0x00007fdd6d084fd0 native:0x0000700002257000 int:0
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `sleep'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `wait'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `block (2 levels) in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `block in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `synchronize'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:161:in `run_hook'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:97:in `block in consume'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `consume'
* #<Thread:0x00007fdd6d880ed0@/Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:93 sleep_forever>
   rb_thread_t:0x00007fdd6d0854d0 native:0x000070000235a000 int:0
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `sleep'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `wait'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `block (2 levels) in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `block in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `synchronize'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:161:in `run_hook'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:97:in `block in consume'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `consume'
* #<Thread:0x00007fdd6d880d68@/Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:93 sleep_forever>
   rb_thread_t:0x00007fdd6d0859d0 native:0x000070000245d000 int:0
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `sleep'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `wait'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:121:in `block (2 levels) in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:105:in `block in wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `synchronize'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:102:in `wait_for_slot'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:161:in `run_hook'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:97:in `block in consume'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `loop'
   /Users/steinybot/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/overcommit-0.48.1/lib/overcommit/hook_runner.rb:94:in `consume'

[sds]

Thanks for confirming this can be reproduced with only built-in Overcommit hooks. Unfortunately I still cannot reproduce, but I appreciate the report.

Would welcome any help investigating this issue from folks who are able to reliably reproduce.

[steinybot]

I can have a go. It's been a long time since I have used Ruby so it might take a while.

[steinybot]

So I finally found the problem. The issue is that in Overcommit::HookRunner.release_slot the other threads are only signalled if there are no hooks left.

Here is an example: There are 2 hooks and @config.concurrency is 2. If parallelize is false on the first hook it will consume both slots. The second thread will pop the second hook and wait for a slot (@hooks_left is now empty). When the first hook finished, that thread goes to release the slots but since there are no hooks left then it fails to signal the second thread.

I'm having a go at creating a test that can reliably reproduce it. I can reproduce it every time on my macbook but I haven't had any lucky on Travis CI yet.

[steinybot]

Ah finally got it https://travis-ci.com/steinybot/overcommit/jobs/214211115