Bug/650 traceback when setting parallelize to false #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a hook is running while another hook tries to start and there are not enough slots left then it will wait for the first hook to stop and release its slots. This first hook will not signal the second if there are no more hooks left. This results in a deadlock. This situation is far more likely to occur when parallelize is false since the hook will consume all the available slots.
steinybot
force-pushed
the
bug/650-traceback-when-setting-parallelize-to-false
branch
from
c14a818 to
ce2ca4b
Compare
…-when-setting-parallelize-to-false
sds
approved these changes
Jul 9, 2019
Owner
sds
left a comment
sds
left a comment
There was a problem hiding this comment.
Thanks for the fix! Really appreciate you coming up with a test that can sometimes reproduce.
steinybot
deleted the
bug/650-traceback-when-setting-parallelize-to-false
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If parallelize is false then a hook will consume all the slots. Other threads may be processing other hooks but will wait for the slots to be released. Therefore a signal must be sent whenever slots are released.
Fixes #650