Fix support for binary files in LineEndings hook #496
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @ajgon! I'm trying to figure out why the specs fail in windows environments. Are you able to explore this? I'm swamped at the moment. Perhaps push a revert of your commit and see if it still breaks? |
Contributor
Author
|
Tried some configurations, and couldn't determine why it behaves this way. I'm closing it, since apparently, the problem occurs only for me, so there is no point of introducing a possible regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LineEndingshook checksgit ls-files --eolindexes forl/-textfor some reason. However, the proper format (at least for git 2.11 and up isi/-text(iinstead ofl).This fix corrects that, while keeping backwards compatibility.