Yarn install #523
Merged
Yarn install #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trotzig
reviewed
Nov 27, 2017
Contributor
trotzig
left a comment
trotzig
left a comment
There was a problem hiding this comment.
Looks good to me, but could you add a test for the hook as well? Something similar to https://github.com/brigade/overcommit/blob/master/spec/overcommit/hook/post_checkout/npm_install_spec.rb
Contributor
Author
|
Oops, sorry I forgot specs! Added. |
trotzig
approved these changes
Nov 29, 2017
Contributor
trotzig
left a comment
trotzig
left a comment
There was a problem hiding this comment.
Thanks! The tests are a little repetitive, but I noticed other hooks do the same thing (e.g. npm-install) so we're all good. 👍
Contributor
|
Sorry for the long turnover here. I completely forgot to check back... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add yarn install to built-in hooks.