Add YarnCheck pre-commit hook #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a hook that checks that a [`yarn.lock`](https://yarnpkg.com) matches the given `package.json`. This is very similar, and mostly copied from, the existing `BundleCheck` pre-commit hook. The primary difference is that `yarn check`'s output needs a bit more massaging. Since it reports a number of issues that are unrelated, or outside the developer's control, check for certain error statements that do indicate the lockfile is out of date.
steverice
force-pushed
the
yarn-check
branch
from
8b1a44b to
36be45a
Compare
sds
approved these changes
Feb 10, 2018
Owner
sds
left a comment
sds
left a comment
There was a problem hiding this comment.
Nice, thanks for writing tests with real-world example output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users of the Yarn package manager.
Add a hook that checks that a
yarn.lockmatches the givenpackage.json. This is very similar, and mostly copied from, the existingBundleCheckpre-commit hook.The primary difference is that
yarn check's output needs a bit more massaging. Since it reports a number of issues that are unrelated, or outside the developer's control, check for certain error statements that do indicate the lockfile is out of date.