Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/overcommit/hook/pre_commit/mdl.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ def run
json_messages.map do |message|
Overcommit::Hook::Message.new(
:error,
message[:filename],
message[:line],
message[:description]
message['filename'],
message['line'],
"#{message['filename']}:#{message['line']} #{message['rule']} #{message['description']}"
)
end
end
Expand Down
5 changes: 5 additions & 0 deletions spec/overcommit/hook/pre_commit/mdl_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

context 'when mdl exits unsuccessfully' do
let(:success) { false }
let(:message) { subject.run.last }

context 'and it reports an error' do
let(:stdout) do
Expand All @@ -34,13 +35,17 @@
let(:stderr) { '' }

it { should fail_hook }
it { expect(message.file).to eq 'file1.md' }
it { expect(message.line).to eq 1 }
it { expect(message.content).to eq 'file1.md:1 MD013 Line length' }
end

context 'when there is an error running mdl' do
let(:stdout) { '' }
let(:stderr) { 'Some runtime error' }

it { should fail_hook }
it { expect(message).to eq 'Some runtime error' }
end
end
end