Add container naming convention for challenges#429
Merged
Conversation
v1bh475u
reviewed
Oct 8, 2025
|
|
||
| func CreateContainerFromImage(containerConfig *CreateContainerConfig) (string, error) { | ||
| containerName := containerConfig.ContainerName | ||
| containerName := fmt.Sprintf("beast_%s_%s", containerConfig.ChallengeName, containerConfig.ContainerName[:3]) |
Contributor
There was a problem hiding this comment.
Maybe we can also incorporate the name of competition. Thoughts?
Author
There was a problem hiding this comment.
Yep, it could be added in the struct and replace beast with comp. name in the container name
But are we taking competition name input anywhere? I didn't see it while running example challs
Contributor
|
@peopleig ,you are mostly done for this issue. I would approve of this PR after you show me demo of this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a 'ChallengeName' to ContainerConfig struct, to incorporate challenge name in the container's name.
The naming will be as such - "beast_<challenge_name>_<random_3_letter_string>"