Add variable number of discriminator updates for each generator update#103
Add variable number of discriminator updates for each generator update#103fealho merged 6 commits intosdv-dev:masterfrom Baukebrenninkmeijer:wgan-critic-implementation
Conversation
csala
left a comment
There was a problem hiding this comment.
Thanks @Baukebrenninkmeijer It looks good!
I would make a couple of minor changes that I think will improve the overall result:
-
I would rename the parameter to something like
discriminator_steps. Otherwise, at first sight someone may thing thatn_discriminators=5means "Use 5 different discriminators". -
Providing some more context in the docstring would be helpful. I would add a sentence to explain what is the effect of increasing or decreasing the value, a link to the WGAN paper, and then mention that the default is 1 to match the original CTGAN implementation.
Would you mind adding these? Once it is done I think we are all set!
|
@csala Done and done |
csala
left a comment
There was a problem hiding this comment.
Looks good now! Thanks @Baukebrenninkmeijer !
Yes, sometimes there are random errors related to the Github Actions infrastructure. I'm re-running the tests. |
|
Hmmm a value count in the samples was too high. But that seems also unrelated with my changes. Is that bound maybe too tight? Its 6550isch when it should be below 6500. |
As per WGAN, the discriminator should be updated 5 times more often than the generator. This is added as a parameter in the
__init__function.Fixes #101