Fixing failing pip check#131
Merged
Merged
Conversation
amontanez24
requested review from
frances-h,
gsheni and
lajohn4747
and removed request for
a team and
frances-h
lajohn4747
approved these changes
Oct 21, 2024
Contributor
lajohn4747
left a comment
lajohn4747
left a comment
There was a problem hiding this comment.
I think this is reasonable, we eventually will move away since python 3.8 is EOL. Also good to finally get past this age of mac arm vs x86 on python
gsheni
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #130
Starting at version 24.2, pip started using the tags on the wheel files as part of its check. The problem is torch mislabeled most of the tags for their wheels on python 3.8. This means that even for the versions that have a wheel matching torch-x.y.z-cp39-none-macosx_11_0_arm64.whl, pip check fails because the wheels are tagged as x86.
We can either limit our pip version to under 24.2 or just run these tests on x86 (macos-13) where the pip check will pass. I went with the latter since this will also let us test on mac with an x86 chip.
The gabrielfalcao/pyenv-action@v18 no longer seems to be working and it doesn't seem to be maintained so I think we can drop it.