-
Notifications
You must be signed in to change notification settings - Fork 50
Add new row synthesis single table metric #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0be9683 to
376bec4
Compare
| if isinstance(columns, set): | ||
| columns = list(columns) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but not sure what columns can be:
You can always cast to list and this will be one dimensional:
In [1]: columns_list = ['a', 'b', 'c']
In [2]: columns_set = {'a', 'b', 'c'}
In [3]: columns_tuple = ('a', 'b', 'c')
In [4]: list(columns_list)
Out[4]: ['a', 'b', 'c']
In [5]: list(columns_set)
Out[5]: ['b', 'c', 'a']
In [6]: list(columns_tuple)
Out[6]: ['a', 'b', 'c']If columns can be a str then don't do this as it will split it in letters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should always be a list or a set.
Codecov ReportBase: 70.18% // Head: 73.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 70.18% 73.60% +3.41%
==========================================
Files 70 72 +2
Lines 2482 2811 +329
==========================================
+ Hits 1742 2069 +327
- Misses 740 742 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pvk-developer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now! ![]()
Resolves #207