Incorrect column name ordering for Multi-Table Synthesizer #2295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2295 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 58 58
Lines 6043 6050 +7
=======================================
+ Hits 5961 5968 +7
Misses 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amontanez24
approved these changes
Nov 14, 2024
frances-h
reviewed
Nov 14, 2024
sdv/multi_table/base.py
Outdated
Comment on lines
531
to
532
| if not hasattr(self, '_original_metadata'): | ||
| self._original_metadata = self.metadata |
Contributor
There was a problem hiding this comment.
Instead of setting this attribute here, maybe we should just use self.get_metadata
tests/unit/multi_table/test_hma.py
Outdated
|
|
||
| assert num_table_cols == estimated_num_columns[table_name] | ||
|
|
||
| def test_column_order(self): |
Contributor
There was a problem hiding this comment.
I think this should be an integration test, not a unit test
frances-h
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b2t3nd6
Resolve #2280
I tested that everything works on SDV-Enterprise, backward compatibility, and CAGs