Improve dtypes benchmark #2393
Merged
Improve dtypes benchmark #2393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2393 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 59 59
Lines 6214 6214
=======================================
Hits 6127 6127
Misses 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rwedge
force-pushed
the
issue-2365-improve-dtypes-benchmark
branch
from
6ad0c34 to
eed8b6a
Compare
rwedge
force-pushed
the
issue-2365-improve-dtypes-benchmark
branch
from
df3b633 to
ee97bc1
Compare
rwedge
commented
Apr 3, 2025
tests/benchmark/utils.py
Outdated
| from tests._external.slack_utils import post_slack_message | ||
|
|
||
| GDRIVE_OUTPUT_FOLDER = '16SkTOyQ3xkJDPJbyZCusb168JwreW5bm' | ||
| GDRIVE_OUTPUT_FOLDER = '1tjre6vNnbAv6jyfsF8N8EZfDX7Rx2HCT' |
Contributor
Author
There was a problem hiding this comment.
will need to revert once code review is complete
rwedge
commented
Apr 3, 2025
tests/benchmark/utils.py
Outdated
| ) | ||
| slack_message = '\n'.join(slack_messages) | ||
| slack_channel = 'sdv-alerts' | ||
| slack_channel = 'sdv-alerts-debug' |
Contributor
Author
There was a problem hiding this comment.
will also need to revert
rwedge
force-pushed
the
issue-2365-improve-dtypes-benchmark
branch
from
7ab670e to
7cfeb4d
Compare
frances-h
reviewed
Apr 11, 2025
Contributor
frances-h
left a comment
frances-h
left a comment
There was a problem hiding this comment.
This is looking really good! Just one minor comment
tests/benchmark/utils.py
Outdated
| ) | ||
|
|
||
| if current_value and not stored_value: | ||
| if current_value == 1.0 and not stored_value == 1.0: |
Contributor
There was a problem hiding this comment.
Should we use stored_value != 1.0 here instead of not stored_value == 1.0?
R-Palazzo
approved these changes
Apr 14, 2025
rwedge
force-pushed
the
issue-2365-improve-dtypes-benchmark
branch
from
4f2144f to
ea09a05
Compare
frances-h
approved these changes
Apr 17, 2025
This reverts commit eb95321.
rwedge
force-pushed
the
issue-2365-improve-dtypes-benchmark
branch
from
ea09a05 to
b93f2e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2365
CU-86b3wt5cy