Fix IndexingError with FixedCombinations constraint#2853
Merged
Conversation
gsheni
requested review from
a team,
amontanez24,
fealho and
frances-h
and removed request for
a team
frances-h
approved these changes
Mar 26, 2026
fealho
reviewed
Mar 26, 2026
Member
fealho
left a comment
fealho
left a comment
There was a problem hiding this comment.
Can you add the integration test from the issue? As long as the test is not too slow.
Contributor
Author
|
@fealho The integration test requires FixedNullCombinations, which is not available in SDV Community |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2853 +/- ##
==========================================
+ Coverage 98.06% 98.08% +0.01%
==========================================
Files 73 73
Lines 8288 8290 +2
==========================================
+ Hits 8128 8131 +3
+ Misses 160 159 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fealho
approved these changes
Mar 26, 2026
amontanez24
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndexingErrorwithFixedCombinationsconstraint during sample #2852