Skip to content

Update categorical labels for FixedCombinations #2864

Merged
gsheni merged 3 commits intomainfrom
issue-1986-fixedcombinations-fixednullcombinations-easy-to-understand-names
Apr 6, 2026
Merged

Update categorical labels for FixedCombinations #2864
gsheni merged 3 commits intomainfrom
issue-1986-fixedcombinations-fixednullcombinations-easy-to-understand-names

Conversation

@gsheni
Copy link
Copy Markdown
Contributor

@gsheni gsheni commented Apr 6, 2026

@gsheni gsheni self-assigned this Apr 6, 2026
@gsheni gsheni requested a review from a team as a code owner April 6, 2026 18:08
@gsheni gsheni requested review from fealho and frances-h and removed request for a team April 6, 2026 18:08
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.03%. Comparing base (8892d29) to head (abf32ab).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdv/cag/fixed_combinations.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2864      +/-   ##
==========================================
- Coverage   98.06%   98.03%   -0.04%     
==========================================
  Files          73       73              
  Lines        8327     8331       +4     
==========================================
+ Hits         8166     8167       +1     
- Misses        161      164       +3     
Flag Coverage Δ
integration 75.74% <78.57%> (-0.03%) ⬇️
unit 97.04% <78.57%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the regression test from the issue?

Comment thread sdv/cag/fixed_combinations.py Outdated
@gsheni gsheni force-pushed the issue-1986-fixedcombinations-fixednullcombinations-easy-to-understand-names branch from e5451a7 to 274f748 Compare April 6, 2026 19:17
@gsheni gsheni requested a review from fealho April 6, 2026 19:20
@gsheni
Copy link
Copy Markdown
Contributor Author

gsheni commented Apr 6, 2026

@fealho it's a bit hard to add an integration test since it relies on ForeignToPrimaryKeySubset which is in SDV-Enterprise. I added a unit test that check the naming with a similar dataset as the issue (test_naming_of_columns_with_fixed_combinations: 274f748)

@sdv-team
Copy link
Copy Markdown
Contributor

sdv-team commented Apr 6, 2026

@sdv-dev sdv-dev deleted a comment from sdv-team Apr 6, 2026
@gsheni gsheni merged commit 0bf0e2d into main Apr 6, 2026
47 checks passed
@gsheni gsheni deleted the issue-1986-fixedcombinations-fixednullcombinations-easy-to-understand-names branch April 6, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FixedCombinations should create columns with easy-to-understand names & values

4 participants