Tests and Fixes for utils-networks-misc.R

[Leo-Send]

Prerequisites

• I adhere to the coding conventions (described here) in my code.
• I have updated the copyright headers of the files I have modified.
• I have written appropriate commit messages, i.e., I have recorded the goal, the need, the needed changes, and the location of my code modifications for each commit. This includes also, e.g., referencing to relevant issues.
• I have put signed-off tags in all commits.
• I have updated the changelog file NEWS.md appropriately.
• I have checked whether I need to adjust the showcase file showcase.R with respect to my changes.
• The pull request is opened against the branch dev.

Description

This Pull request fixes #242

Changelog

Added

• Add new assert.sparse.matrices.equal function to compare two sparse matrices for equality for testing purposes (PR Tests and Fixes for utils-networks-misc.R #248, 9784cdf, d9f1a8d)
• Add tests for file util-networks.misc.R for issue Tests for functionality in util-networks-misc.R #242 (PR Tests and Fixes for utils-networks-misc.R #248, f3202a6, 030574b, 380b022, 8b803c5, 7335c3d, 6b600df)

Changed/Improved

• Enhance get.author.names.from.network and get.author.names.from.data to always have the same output format. Now it doesn't depend on the global flag anymore (PR Tests and Fixes for utils-networks-misc.R #248, d87d325, ddbfe68)
• Change util-tensor.R to correctly use the new output format of get.author.names.from.network (PR Tests and Fixes for utils-networks-misc.R #248, 72b663e)
• Fix convert.adjacency.matrix.list.to.array to throw an error if the function is called with wrong parameters (PR Tests and Fixes for utils-networks-misc.R #248, ece2d38, 1a3e510)
• Rename compare.networks to assert.networks.equal to better match the purpose of the function (PR Tests and Fixes for utils-networks-misc.R #248, d9f1a8d)

Fixed

• Fix get.expanded.adjacency to work if the provided author list does not contain all authors from network and add a warning when that happens since it causes some authors from the network to be lost in the resulting matrix (PR Tests and Fixes for utils-networks-misc.R #248, ff59017)
• Fix get.expanded.adjacency.matrices to have correct names for the columns and rows (PR Tests and Fixes for utils-networks-misc.R #248, e72eff8)
• Fix get.expanded.adjacency.cumulated so that it works if weighted parameter is set to FALSE (PR Tests and Fixes for utils-networks-misc.R #248, 2fb9a5d)

[hechtlC]

The pull request looks good. Thanks for the new tests and the fixes @Leo-Send !
I have just found some small issues that need to be fixed. After they have been fixed and @bockthom is fine with the changes, we can merge the PR.

[bockthom]

Looks good to me @Leo-Send, I only found "a few" indentation or formatting issues 😉
I am not sure if you use tabs or spaces during implementation - it might be that the wrong indentation comes from using tabs instead of spaces - if so, please configure your IDE in such a way that it does not use tabs.

And there is one line where the code should be made fail save (but nothing critical, so no need to adjust the NEWS), and sometimes an additional comment would be helpful. See my detailed comments below.