Merged
Conversation
Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
It was seen on larger Microkit systems that the loader data was overlapping with the code for the loader itself when the loader attempted to copy the data to the appropriate location before jumping to seL4 and starting the system. I believe the root cause of this problem is not gone and will involve changing the tool to be smarter with how it allocates physical memory, my current attempts to do so lead to other issues. I'll have to make a follow up fix to prevent this from happening again, but for now this will allow users of the MaaXBoard to run larger Microkit systems. Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was seen on larger Microkit systems that the loader data was
overlapping with the code for the loader itself when the loader
attempted to copy the data to the appropriate location before
jumping to seL4 and starting the system.
I believe the root cause of this problem is not gone and will involve
changing the tool to be smarter with how it allocates physical memory,
my current attempts to do so lead to other issues. I'll have to make a
follow up fix to prevent this from happening again, but for now this
will allow users of the MaaXBoard to run larger Microkit systems.
This PR also adds a patch to make sure that if overlapping does occur,
we find it at build time instead of having weird errors at runtime.