loader: handle non-PSCI ARM platforms better#457
Merged
Ivan-Velickovic merged 1 commit intomainfrom Mar 30, 2026
Merged
Conversation
This makes things slightly better, main thing is that we make sure we don't try boot secondary CPUs via PSCI if it's unavailable. Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
|
|
||
| return ret; | ||
| #else | ||
| LDR_PRINT("ERROR", 0, "unknown CPU start method for this platform"); |
Contributor
There was a problem hiding this comment.
This might as well be a compile error?
Collaborator
Author
There was a problem hiding this comment.
Resolved offline, cpus.c is always compiled so would need to split it out for exceptions where SMP is just unsupported (e.g Kria26). Just leave as run-time error for now...
| arm_spin_table_cpu_start(logical_cpu, (uint64_t)sp); | ||
| return 0; | ||
| #else | ||
| #elif !defined(ARM_PSCI_UNAVAILABLE) |
Contributor
There was a problem hiding this comment.
I think it makes more sense to have it as like, SMP_BOOT_METHOD == ARM_PSCI or SMP_BOOT_METHOD == SPIN_TABLE or w/e (not if-def'd)
Collaborator
Author
There was a problem hiding this comment.
Talked in-person with @midnightveil , SMP_BOOT_METHOD doesn't really work well when you still need to skip PSCI version checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes things slightly better, main thing is that we make sure we don't try boot secondary CPUs via PSCI if it's unavailable.