libsel4test: static_assert sizeof() mismatches & check against unsigned char support #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would previously fail at runtime, but we can fail the build
instead and catch this earlier.
In file included from /src/helpers.h:13,
from /src/tests/ipc.c:13:
/projects/sel4test/apps/sel4test-tests/src/tests/ipc.c:
In function ‘test_ipc_pair’:
/projects/seL4_libs/libsel4test/include/sel4test/test.h:243:10:
error: static assertion failed: "sizeof(res) does not match
sizeof(SUCCESS), use of test_eq incorrect"
243 | _Static_assert(sizeof(_a) == sizeof(_b), \
| ^~~~~~~~~~~~~~
/projects/seL4_libs/libsel4test/include/sel4test/test.h:270:24:
note: in expansion of macro ‘test_op’
270 | #define test_eq(a, b) test_op(a, b, ==)
| ^~~~~~~
/projects/sel4test/apps/sel4test-tests/src/tests/ipc.c:347:25:
note: in expansion of macro ‘test_eq’
347 | test_eq(res, SUCCESS);
| ^~~~~~~
Signed-off-by: julia <git.ts@trainwit.ch>
On arm-none-elf-eabi-gcc, -fshort-enums is on by default and is compatible with unsigned char (but not *signed* char) so we need to add support for this to the test_op macros. Also, _test_abort() when these type failures happen so that the failure is more obviously an issue with the compiler/test setup, not the tests themselves. Signed-off-by: julia <git.ts@trainwit.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1:
This would previously fail at runtime, but we can fail the build
instead and catch this earlier.
Commit 2:
On arm-none-elf-eabi-gcc, -fshort-enums is on by default and
is compatible with unsigned char (but not signed char) so we
need to add support for this to the test_op macros.
Also, _test_abort() when these type failures happen so that the
failure is more obviously an issue with the compiler/test setup,
not the tests themselves.
Test with: seL4/sel4test#145