Reduce dependency on vgic_dist_device#66
Merged
kent-mcleod merged 2 commits intoseL4:masterfrom Jul 9, 2022
Merged
Conversation
Member
|
My preference is that we hold back these clean-up PRs until after GICv3 emulation support is merged. |
Member
Author
If adding GICv3 support is urgent for you, then I will hold this back. |
axel-h
force-pushed
the
patch-axel-6
branch
2 times, most recently
from
23c5f1d to
4393a3d
Compare
kent-mcleod
reviewed
Jul 9, 2022
kent-mcleod
reviewed
Jul 9, 2022
added 2 commits
July 10, 2022 01:26
Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
Pass dedicated parameters to the internal fault handlers. Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
kent-mcleod
approved these changes
Jul 9, 2022
Member
kent-mcleod
left a comment
kent-mcleod
left a comment
There was a problem hiding this comment.
I'd like to merge this before #58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vgicto internal functions and notvgic_dist_deviceto reduce dependenciesThe way I understand the code is, that
vgicis the main object we work with internally. Thevgic_dist_deviceseem something that describes the mapping. I'm not sure where this is really needed nowadays, maybe in a non-CAmkES environment there are usecases. But this is completely internal, so my longterm-goal is droping this completely and store the information invgic, see top commit of https://github.com/Hensoldt-Cyber/seL4_projects_libs/commits/patch-axel-6a. I just have to check how well this works with the GICv3 support that #58 brings in.