Correction for the description of luaL_typename#166
Merged
deviaze merged 5 commits intoseal-runtime:mainfrom Feb 16, 2026
Merged
Correction for the description of luaL_typename#166deviaze merged 5 commits intoseal-runtime:mainfrom
luaL_typename#166deviaze merged 5 commits intoseal-runtime:mainfrom
Conversation
Backend of `typeof`: https://github.com/luau-lang/luau/blob/54a2ea00831df4c791e6cfc896a98da75d1ae126/VM/src/lbaselib.cpp#L210 Returns `"no value"` when index is out-of-bounds (bear with me): Only does this if `luaA_toobject` is null: https://github.com/luau-lang/luau/blob/54a2ea00831df4c791e6cfc896a98da75d1ae126/VM/src/laux.cpp#L353 Only does this if `index2addr` returns `luaO_nilobject`: https://github.com/luau-lang/luau/blob/54a2ea00831df4c791e6cfc896a98da75d1ae126/VM/src/lapi.cpp#L126 Only does this if index is out-of-bounds: https://github.com/luau-lang/luau/blob/54a2ea00831df4c791e6cfc896a98da75d1ae126/VM/src/lapi.cpp#L108
deviaze
reviewed
Feb 15, 2026
deviaze
previously requested changes
Feb 15, 2026
Collaborator
deviaze
left a comment
deviaze
left a comment
There was a problem hiding this comment.
I think the C-Stack API quite confusing coming from someone who only knows the mluau api or other sane apis in higher level languages.
Co-authored-by: Dev Chrysalis Dalal <dev@deviaze.com>
Contributor
Author
|
Yeah I didn't intend to remove that line on purpose |
Collaborator
|
thanksss :) 🦭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend of
typeof:https://github.com/luau-lang/luau/blob/54a2ea00831df4c791e6cfc896a98da75d1ae126/VM/src/lbaselib.cpp#L210
Returns
"no value"when index is out-of-bounds (bear with me): Only does this ifluaA_toobjectis null:https://github.com/luau-lang/luau/blob/54a2ea00831df4c791e6cfc896a98da75d1ae126/VM/src/laux.cpp#L353
Only does this if
index2addrreturnsluaO_nilobject: https://github.com/luau-lang/luau/blob/54a2ea00831df4c791e6cfc896a98da75d1ae126/VM/src/lapi.cpp#L126Only does this if index is out-of-bounds:
https://github.com/luau-lang/luau/blob/54a2ea00831df4c791e6cfc896a98da75d1ae126/VM/src/lapi.cpp#L108