Skip to content

Conversation

@mikewuu
Copy link
Contributor

@mikewuu mikewuu commented May 24, 2025

Closes https://linear.app/seam/issue/CX-323/fix-how-format-is-displayed-for-properties

https://hello-seam.slack.com/archives/C07DTP6EGBZ/p1748017069369499

CleanShot 2025-05-24 at 11 53 01@2x

Needed manually add to the map from Blueprint parameter -> endpoint parameter via mapBlueprintParamToEndpointParam, which includes the variables referenced in the hbs templates.

@mikewuu mikewuu requested a review from a team as a code owner May 24, 2025 02:53
@seambot seambot requested a review from a team as a code owner May 24, 2025 02:53
@mikewuu mikewuu requested a review from DebbieAtSeam May 24, 2025 02:54
Copy link
Contributor

@DebbieAtSeam DebbieAtSeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @andrii-balitskyi already had this set up somewhere to display these types with initial caps, such as "String" and "Boolean."

@mikewuu
Copy link
Contributor Author

mikewuu commented May 26, 2025

I think @andrii-balitskyi already had this set up somewhere to display these types with initial caps, such as "String" and "Boolean."

Do you mean normalizePropertyFormatForDocs for properties maybe?

I don't see anything for formatting jsonType and this seems to be the only place that it's rendered in the template.

I've updated it in c7d5b9c to be capitalized as well.

@mikewuu mikewuu requested a review from DebbieAtSeam May 26, 2025 03:25
@mikewuu mikewuu merged commit d106c5e into main May 26, 2025
14 checks passed
@mikewuu mikewuu deleted the param-json-type branch May 26, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants