Skip to content

Conversation

@mikewuu
Copy link
Contributor

@mikewuu mikewuu commented Jun 25, 2025

@mikewuu mikewuu requested review from a team as code owners June 25, 2025 09:25
## Response
{{#if response.resourceType}}{{#if (eq response.responseType "resource_list")}}Array of [{{response.escapedResourceType}}s](./){{else}}[{{response.escapedResourceType}}](./){{/if}}{{else}}void{{/if}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this produce a link to the page for the resource, or is it always just a "fake" link that just goes to the top of the same page?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is supposed to work. Will file issue to fix it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually @DebbieAtSeam this seems to be working ok for me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this link "pattern" only works if the returned resource is the parent resource of the endpoint (that is, the link says to go to the readme in the same directory, correct?). If the return value is an action attempt (or if the endpoint were to return a different resource), we'd need a more explicit link, no? Would this pattern work for an Instant Key as a return type too? How about for /access_codes/generate_code?

@razor-x
Copy link
Member

razor-x commented Jun 25, 2025

@mikewuu Had to adjust the implementation a bit to use the resource samples from the blueprint.

@razor-x razor-x merged commit d287db2 into main Jun 25, 2025
14 checks passed
@razor-x razor-x deleted the resource-sample branch June 25, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants