-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add endpoint resource samples #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ## Response | ||
| {{#if response.resourceType}}{{#if (eq response.responseType "resource_list")}}Array of [{{response.escapedResourceType}}s](./){{else}}[{{response.escapedResourceType}}](./){{/if}}{{else}}void{{/if}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this produce a link to the page for the resource, or is it always just a "fake" link that just goes to the top of the same page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is supposed to work. Will file issue to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually @DebbieAtSeam this seems to be working ok for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this link "pattern" only works if the returned resource is the parent resource of the endpoint (that is, the link says to go to the readme in the same directory, correct?). If the return value is an action attempt (or if the endpoint were to return a different resource), we'd need a more explicit link, no? Would this pattern work for an Instant Key as a return type too? How about for /access_codes/generate_code?
|
@mikewuu Had to adjust the implementation a bit to use the resource samples from the blueprint. |
Closes https://linear.app/seam/issue/CX-332/fill-in-sample-resource-in-response
Standard Resource
Action Attempt