This repository was archived by the owner on Nov 15, 2024. It is now read-only.
fix: Add type property to AccessCodeUpdateBaseRequest#243
Merged
Conversation
xplato
commented
Jul 18, 2023
xplato
commented
Jul 18, 2023
| > & | ||
| AccessCodeUpdateBaseRequest | ||
| AccessCodeUpdateBaseRequest & { | ||
| type?: "time_bound" |
Contributor
Author
There was a problem hiding this comment.
@codetheweb Pretty sure this will unblock the type issues for Space backend.
codetheweb
approved these changes
Jul 18, 2023
Contributor
|
🎉 This PR is included in version 7.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently hitting type blocks updating the endpoint for space-backend. Looks like this is a supported property in Connect.