Add delete noise threshold method #88
Conversation
andrii-balitskyi
requested review from
codetheweb,
razor-x and
seveibar
as code owners
seamapi/noise_thresholds.py
Outdated
| noise_threshold_decibels: Optional[float] = None, | ||
| noise_threshold_nrs: Optional[float] = None, | ||
| ) -> List[NoiseThreshold]: | ||
| ) -> ActionAttempt: |
There was a problem hiding this comment.
I think we should return a noise threshold here, not an action attempt
There was a problem hiding this comment.
https://github.com/seamapi/seam-connect/issues/2919
I guess we can't fix this yet
There was a problem hiding this comment.
from https://github.com/seamapi/seam-connect/issues/2919
Is this possible to do using tiny actions? for example, until we run the action we don't have the device metadata and the noide_threshold_id
There was a problem hiding this comment.
@seveibar for now we can by default poll for the action attempt until resolved and return the noise threshold which should be in the result of the successfully resolved action attempt
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
lg, we should try to get the types correct, but since this is versioned we can do it incrementally if you'd like
## [2.12.0](seamapi/python@v2.11.0...v2.12.0) (2023-05-17) ### Features * Add delete noise threshold method ([#88](seamapi/python#88)) ([27b0005](seamapi/python@27b0005))
|
🎉 This issue has been resolved in version 2.12.0 🎉 The release is available on PyPI and GitHub. |
No description provided.