make it possible to use client session tokens with SeamProvider #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewuu
approved these changes
May 19, 2023
razor-x
reviewed
May 24, 2023
| 'Cannot provide both a clientSessionToken and a publishableKey .' | ||
| ) | ||
| } | ||
| // No reason to ban this behavior, but it's unnecessary. |
Member
There was a problem hiding this comment.
@seveibar The rational to do this is prevent an all to common frustrating scenario where users don't know why something is not working as expected. In this case, a user may wonder why stuff is not working because they think they are only passing one option, or they do not realize which option will 'win'. I recommend we put this check back for better ux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.