Skip to content

fix: Hide pin code related fields if cannot specify #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 7, 2025
Merged

fix: Hide pin code related fields if cannot specify #674

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2ef28c
feat: Hide pin code related fields if cannot specify
kadiryazici Jan 29, 2025
66795eb
ci: Format code
seambot Jan 29, 2025
da88778
update packages
kadiryazici Feb 4, 2025
07c9193
Merge branch 'main' of https://github.com/seamapi/react into kadir/cx…
kadiryazici Feb 4, 2025
7b6837e
fix import
kadiryazici Feb 4, 2025
2cdceb7
Update condition
kadiryazici Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 50 additions & 34 deletions src/lib/seam/components/AccessCodeDetails/AccessCodeDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
} from 'lib/seam/components/common-props.js'
import { NestedDeviceDetails } from 'lib/seam/components/DeviceDetails/DeviceDetails.js'
import { NestedEditAccessCodeForm } from 'lib/seam/components/EditAccessCodeForm/EditAccessCodeForm.js'
import { useDevice } from 'lib/seam/devices/use-device.js'
import {
accessCodeErrorFilter,
accessCodeWarningFilter,
Expand Down Expand Up @@ -94,6 +95,12 @@ export function AccessCodeDetails({
)
}, [accessCode, deleteCode, onDelete, preventDefaultOnDelete])

const { device } = useDevice({ device_id: accessCode?.device_id })
const canSpecifyPinCode =
device?.properties.code_constraints?.every(
({ constraint_type: type }) => type !== 'cannot_specify_pin_code'
) ?? true

if (accessCode == null) {
return null
}
Expand Down Expand Up @@ -192,18 +199,23 @@ export function AccessCodeDetails({
alerts.length > 0 && 'seam-top-has-alerts'
)}
>
<span className='seam-label'>{t.accessCode}</span>
<h5 className='seam-access-code-name'>{name}</h5>
<div className='seam-code'>
<span>{accessCode.code}</span>
<IconButton
onClick={() => {
void copyToClipboard(accessCode.code ?? '')
}}
>
<CopyIcon />
</IconButton>
</div>
{canSpecifyPinCode && (
<>
<span className='seam-label'>{t.accessCode}</span>
<h5 className='seam-access-code-name'>{name}</h5>
<div className='seam-code'>
<span>{accessCode.code}</span>
<IconButton
onClick={() => {
void copyToClipboard(accessCode.code ?? '')
}}
>
<CopyIcon />
</IconButton>
</div>
</>
)}

<div className='seam-duration'>
<Duration accessCode={accessCode} />
</div>
Expand All @@ -215,28 +227,32 @@ export function AccessCodeDetails({
onSelectDevice={selectDevice}
/>
</div>
{(!disableEditAccessCode || !disableDeleteAccessCode) && (
<div className='seam-actions'>
{!disableEditAccessCode && !accessCode.is_offline_access_code && (
<Button
size='small'
onClick={handleEdit}
disabled={isAccessCodeBeingRemoved || isDeleting}
>
{t.editCode}
</Button>
)}
{!disableDeleteAccessCode && !accessCode.is_offline_access_code && (
<Button
size='small'
onClick={handleDelete}
disabled={isAccessCodeBeingRemoved || isDeleting}
>
{t.deleteCode}
</Button>
)}
</div>
)}

{canSpecifyPinCode &&
(!disableEditAccessCode || !disableDeleteAccessCode) && (
<div className='seam-actions'>
{!disableEditAccessCode && !accessCode.is_offline_access_code && (
<Button
size='small'
onClick={handleEdit}
disabled={isAccessCodeBeingRemoved || isDeleting}
>
{t.editCode}
</Button>
)}
{!disableDeleteAccessCode &&
!accessCode.is_offline_access_code && (
<Button
size='small'
onClick={handleDelete}
disabled={isAccessCodeBeingRemoved || isDeleting}
>
{t.deleteCode}
</Button>
)}
</div>
)}

<div className='seam-details'>
{!disableResourceIds && (
<div className='seam-row'>
Expand Down
Loading