Handle missing PGXS gracefully when running tests#59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pg_config --pgxspoints to a non-existentpgxs.mkso test targets and other non-build flows can still be evaluated.Description
HAVE_PGXS := $(if $(wildcard $(PGXS)),1,0)and conditionallyinclude $(PGXS)with a clear warning inmakefilewhen PGXS is missing, allowingmaketo continue.Testing
make test-core, which now emits the PGXS warning and proceeds to invokepg_provebut the run failed becausepg_proveis not installed (Error 127).pytest -qearlier which reported "no tests ran" since there are no Python tests in this repository.Codex Task