fix: render special permission bits#132
Conversation
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
|
Warning Review limit reached
More reviews will be available in 38 minutes and 26 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. 📝 WalkthroughWalkthroughThe PR adds a long-format file-type classifier for sockets, FIFOs, character devices, and block devices, threads that classification through file details, icons, name styling, and type indicators, and updates permission formatting for setuid, setgid, and sticky bits. Tests cover the new mappings and rendered output. ChangesFilesystem type and display formatting
Sequence Diagram(s)sequenceDiagram
participant ComponentA
participant ComponentB
ComponentA->>ComponentB: observable interaction
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -10 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/structs.rs`:
- Around line 111-118: The public enum NameStyle now has additional variants,
which is a breaking API change for downstream users of the re-export in lib.rs.
Update Cargo.toml to reflect the required major version bump before publishing,
and make sure the version change is aligned with the NameStyle enum expansion so
consumers can rely on semver expectations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3325b579-5834-4ece-9aa7-91db367ed719
📒 Files selected for processing (9)
src/structs.rssrc/utils/file.rssrc/utils/format.rssrc/utils/icons.rssrc/utils/render.rstests/crate/file.rstests/crate/icons.rstests/crate/render.rstests/format.rs
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Updates long-format Unix metadata rendering so special permission bits and special file types are displayed consistently.
Long-format permissions now render setuid, setgid, and sticky modes with s/S/t/T. Unix special file types now use standard type characters for sockets, FIFOs, character devices, and block devices, with matching name colors and Nerd Font icons where icons are enabled.
The shared file-type classifier now drives long-format type chars, name styling, icon selection, and indicator suffixes. Existing GNU-style suffix behavior is preserved for directories, symlinks, FIFOs, and sockets; executable * indicators apply only to regular executable files.
Summary by CodeRabbit
New Features
Bug Fixes