Merged
Conversation
twelch
suggested changes
Jul 16, 2024
Contributor
twelch
left a comment
twelch
left a comment
There was a problem hiding this comment.
Nice work with this PR @avmey and finding the issue. In the process of reviewing it I found a small bug. I also felt the new code for setting the default value code of the histogram should get moved up and reworked. I went ahead and did this in an add-on PR #316. Please feel free to take a look and merge if you're happy with it. I'm happy to review with you.
* fix no overlap check, shift histo default stat value calc, shift Histogram export * move area default value init, improve comments * nits
twelch
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rasterStats would empty histograms when no overlap was present. Updates rasterStats to return valid histogram metrics for all
categoryMetricValues. Tested in california-reports