fix: staple macOS app before packaging DMG#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.appas a zip and staple the app before copying it into the DMG staging directory.base64 -dfor portable short-option usage.Why
The manual package workflow produced a successful x64 DMG, but local validation showed the DMG itself was stapled while the
Diffy.appinside the mounted DMG was not. The previous script stapleddist/packages/Diffy.appafter creating the DMG, so the shipped copy inside the DMG missed the app ticket.Validation
bash -n scripts/package-macos-release.sh.github/workflows/package.yml25410588037confirmed secrets/certificate import and x64 DMG notarization, and exposed the missing app-ticket issue in the mounted app.