Skip to content

Fix/refresh token for contact jobs#632

Merged
herpaderpaldent merged 5 commits into3.xfrom
fix/refresh_token_for_contact_jobs
Mar 31, 2023
Merged

Fix/refresh token for contact jobs#632
herpaderpaldent merged 5 commits into3.xfrom
fix/refresh_token_for_contact_jobs

Conversation

@herpaderpaldent
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Mar 31, 2023

PR Summary

  • Removed HasRequiredScopes trait from contact jobs
    Yar mateys, we be removin' a trait not needed anymore from all contact jobs
  • Introduced ContactBaseJob
    Ahoy, added a new ContactBaseJob which takes care of the required scope interface and path values fer us
  • Moved getRefreshToken() method and added tests
    Arr, the getRefreshToken() method be moved to ContactBaseJob, and we be addin' tests in the JobTest class to ensure smooth sailin'

@herpaderpaldent herpaderpaldent merged commit c3134a1 into 3.x Mar 31, 2023
@herpaderpaldent herpaderpaldent deleted the fix/refresh_token_for_contact_jobs branch March 31, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant