Skip to content

Fix/handle unknown schedule jobs#641

Merged
herpaderpaldent merged 4 commits into3.xfrom
fix/handle-unknown-schedule-jobs
Apr 22, 2024
Merged

Fix/handle unknown schedule jobs#641
herpaderpaldent merged 4 commits into3.xfrom
fix/handle-unknown-schedule-jobs

Conversation

@herpaderpaldent
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Apr 22, 2024

PR Summary

  • Added Ability to Limit Data Retrieval Rate
    We added a new feature to the RetrieveFromEsiBase class that limits the rate of data gathering calls. This 'RateLimitsEsiCalls' trait ensures we don't fetch more data than we need, arrr!
  • Improved Scheduler Safety
    Before adding a task to our schedule in the EveapiServiceProvider we now check if its job class actually exists. This helps avoid unexpected surprises that might knock the wind out of our sails.
  • Added Flexibility to Exceptions
    We've made changes to the InvalidContainerDataException and RateLimitedException classes to accept 'nullable' data. This means they can now handle situations where no data is provided, making them more resilient.
  • Enhanced Security for Job Classes
    We've implemented a new trait called HasRequiredScopes to CharacterAssetsNameJob and CharacterContractsJob classes. This bit of code verifies that the requester has the necessary permissions before executing the task, arrr!
  • Code Clean-up
    We've removed a duplicate trait from the CorporationMemberTrackingJob class and tidied up the order of traits in multiple job classes.
  • Improved Search Functionality in the Asset Model
    In the Asset model, we've made the terms parameter nullable. This allows users to conduct searches even when some terms are left blank, giving the model more flexibility.
  • Code Reorganization in the Refresh Token
    In the RefreshToken model, we've optimized the ordering of traits to improve code readability.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit c612f1e and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 66.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.0% (0.0% change).

View more on Code Climate.

@herpaderpaldent herpaderpaldent merged commit 52ba6cb into 3.x Apr 22, 2024
@herpaderpaldent herpaderpaldent deleted the fix/handle-unknown-schedule-jobs branch April 22, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant