Skip to content

Feature/improved assets#642

Merged
herpaderpaldent merged 3 commits into3.xfrom
feature/improved-assets
Apr 29, 2024
Merged

Feature/improved assets#642
herpaderpaldent merged 3 commits into3.xfrom
feature/improved-assets

Conversation

@herpaderpaldent
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Apr 29, 2024

PR Summary

  • Package Replacement in composer.json
    The package nunomaduro/larastan be replaced to larastan/larastan.

  • A Change in the Field Generator
    The name generator in GroupFactory.php now be producin' first names instead of full names.

  • Database Table Enhancement
    Added the file 2024_04_23_180919_extend_assets_columns.php to include more columns in the assets table in the database.

  • Additional File Inclusion
    The file extension.neon from larastan/larastan now be included in phpstan.neon.dist.

  • Property Name Change
    In CharacterAssetJob.php, the property $known_assets be renamed to $assets.

  • New Job File Additions
    Two fresh job files, EnrichAssetTypeGroupCategoryJob.php and UpdateAssetSystemRegionJob.php been added. These be meant to enhance assets with incomplete group, category, system, and region information.

  • Update in Job Queues
    The newly minted jobs be added to the assets job queue in CharacterBatchJob.php and to the maintenance batch in MaintenanceJob.php.

  • Model File Update
    In Asset.php, type_name_normalized column added to fillable array, and the type() method updated to return a HasOne relationship instead of a BelongsTo one. Similar changes been made to Group.php and Type.php files.

  • New Test Files
    Three new test files be added to test the newly added jobs.

  • Test File Update
    In the MaintenanceJobTest.php, AssetModelTest.php, and Pest.php test files, minor changes and updates been made to import and test the new job classes and functionalities.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit ba90612 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 95.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.0% (0.0% change).

View more on Code Climate.

@herpaderpaldent herpaderpaldent merged commit a02c2b4 into 3.x Apr 29, 2024
@herpaderpaldent herpaderpaldent deleted the feature/improved-assets branch April 29, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant