Merged
Conversation
Refactor CharacterInfoFactory to handle corporation affiliation updates efficiently.
This commit updates the `configure` method in `CharacterAffiliationFactory` to handle the logic of updating the alliance of a corporation based on the `alliance_id` set in the `CharacterAffiliation` model. If the corporation exists, the alliance is updated; otherwise, a new corporation is created with the alliance details. This change ensures accurate handling of corporation alliances in the factory.
This commit introduces `pestphp/pest-plugin-type-coverage` to the `composer.json` file, enhancing CI test coverage.
…acterContractsJob Updated ThroughContractsFinder and CharacterContractsJob to remove `@phpstan-ignore-line` comments for cleaner code.
|
Code Climate has analyzed commit a926a13 and detected 15 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 91.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 89.9% (0.0% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.