Skip to content

Fix/failing character update#652

Merged
herpaderpaldent merged 7 commits into3.xfrom
fix/failing-character-update
Jun 26, 2024
Merged

Fix/failing character update#652
herpaderpaldent merged 7 commits into3.xfrom
fix/failing-character-update

Conversation

@herpaderpaldent
Copy link
Contributor

@herpaderpaldent herpaderpaldent commented Jun 26, 2024

This PR addresses #650

For reasons unknown to me, it was possible to have a Character Batch Job dispatched, but no CharacterAfilliation. This broke the CharacterBatchJob because it attempted to access the corporation_id and the previous implementation of the job was under the assumption, that the corporation_id will always be present.

This PR caters for the issue and refactor the job.

…acterBatchJob

This commit adds the CharacterAffiliationJob to the CharacterBatchJobTest and CharacterBatchJob files in order to include character affiliation information in the batch job processing.
@what-the-diff
Copy link

what-the-diff bot commented Jun 26, 2024

PR Summary

Yarr! Here be the treasure of all changes:

  • Updated workflow version in fix-php-code-style-issues
    Our ship's workflow now be using a newer version of the aglipanci/laravel-pint-action. This promises smoother sailing.

  • Removed empty function bodies
    We've cleared the deck, removing useless baggage. Several empty function bodies providing no value were shown the plank.

  • CharacterAffiliationJob addition and peak efficiency in CharacterBatchJobTest
    A new worker, CharacterAffiliationJob, join our crew in CharacterBatchJobTest. Also, we've taught all hands on deck to work more efficiently, using an array to check if every queued task really exists.

  • Typos corrected and type declaration updated
    We corrected the course with typos in GetLocationFlagNameService. And order was established by adding proper type declarations in the ResolveLocationService constructor.

  • Utility addition in CharacterBatchJobTest
    Smart as an albatross we are! We've added a helper, isInstanceOfClassInArray to CharacterBatchJobTest, helping in navigation.

  • Improvements in Testing
    The tests in BalanceTest and UniverseSystemModelTest have been improved for accuracy and efficiency, swapping out the ol' ways for newer techniques.

  • Markdown formatting enhanced in response
    Finally, we polished our communication - improved markdown formatting in the response will make things clearer to all hands on deck.

Refactor the resetBatchUpdate method in the CharacterBatchJob class to improve readability and maintainability. Remove unnecessary comments and update method signature for clarity.
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit e5e51ff and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 98.1% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.9% (0.0% change).

View more on Code Climate.

@herpaderpaldent herpaderpaldent merged commit bbf883b into 3.x Jun 26, 2024
@herpaderpaldent herpaderpaldent deleted the fix/failing-character-update branch June 26, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue in Character Batch Job, Error appears in failed jobs list. error below.

1 participant