Conversation
…acterBatchJob This commit adds the CharacterAffiliationJob to the CharacterBatchJobTest and CharacterBatchJob files in order to include character affiliation information in the batch job processing.
PR SummaryYarr! Here be the treasure of all changes:
|
Refactor the resetBatchUpdate method in the CharacterBatchJob class to improve readability and maintainability. Remove unnecessary comments and update method signature for clarity.
|
Code Climate has analyzed commit e5e51ff and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 98.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 89.9% (0.0% change). View more on Code Climate. |
This PR addresses #650
For reasons unknown to me, it was possible to have a Character Batch Job dispatched, but no CharacterAfilliation. This broke the CharacterBatchJob because it attempted to access the corporation_id and the previous implementation of the job was under the assumption, that the corporation_id will always be present.
This PR caters for the issue and refactor the job.