Skip to content

remove necessary artisan call to improve time#1357

Merged
herpaderpaldent merged 2 commits into3.xfrom
improve/test_runtime
Mar 24, 2023
Merged

remove necessary artisan call to improve time#1357
herpaderpaldent merged 2 commits into3.xfrom
improve/test_runtime

Conversation

@herpaderpaldent
Copy link
Copy Markdown
Contributor

No description provided.

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Mar 24, 2023

PR Summary

  • Update phpunit.xml - Added APP_ENV=testing to ensure the right environment for tests.
  • Removed setupDatabase() from TestCase::setUp() - Improved tests by removing unnecessary database setup, relying on .env for database connection.

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 1ace258 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.7%.

View more on Code Climate.

@herpaderpaldent herpaderpaldent merged commit 202a50e into 3.x Mar 24, 2023
@herpaderpaldent herpaderpaldent deleted the improve/test_runtime branch March 24, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant